From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF8yn-0003UC-Lp for qemu-devel@nongnu.org; Fri, 21 Sep 2012 15:33:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TF8ym-0007Vn-AS for qemu-devel@nongnu.org; Fri, 21 Sep 2012 15:33:37 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:60161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF8ym-0007Vj-3x for qemu-devel@nongnu.org; Fri, 21 Sep 2012 15:33:36 -0400 Received: by pbbrp12 with SMTP id rp12so8360040pbb.4 for ; Fri, 21 Sep 2012 12:33:35 -0700 (PDT) Sender: Richard Henderson Message-ID: <505CC10C.6050505@twiddle.net> Date: Fri, 21 Sep 2012 12:33:32 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1348245809-13482-1-git-send-email-aurelien@aurel32.net> In-Reply-To: <1348245809-13482-1-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/10] tcg/mips: cleanup and improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 09/21/2012 09:43 AM, Aurelien Jarno wrote: > This patch series first does a bit of cleanup and bug fixing on the > MIPS TCG backend. Then some optimizations are added, mostly by > implementing new TCG operations. The last patch depends on the movcond > series by Richard Henderson. > > This has been tested on Loongson3A and Octeon CPUs by booting arm, i386, > x86_64 and ppc guests. > > Aurelien Jarno (10): > tcg-mips: fix wrong usage of 'Z' constraint > tcg/mips: kill warnings in user mode > tcg/mips: use TCGArg or TCGReg instead of int > tcg/mips: don't use global pointer > tcg/mips: use stack for TCG temps > tcg/mips: optimize brcond arg, 0 > tcg/mips: optimize bswap{16,16s,32} on MIPS32R2 > tcg/mips: implement rotl/rotr ops on MIPS32R2 > tcg/mips: implement deposit op on MIPS32R2 > tcg/mips: implement movcond op on MIPS32R2 > > tcg/mips/tcg-target.c | 336 +++++++++++++++++++++++++++++++++++-------------- > tcg/mips/tcg-target.h | 25 +++- > 2 files changed, 266 insertions(+), 95 deletions(-) > While I didn't double-check the actual instruction encodings, I looked through the patches for typos and logic errors. I didn't see anything except for patch 4 re the handling of the global pointer. That patch is fine as written, though I believe it could be improved. Reviewed-by: Richard Henderson r~