qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Don Slutz <Don@CloudSwitch.Com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: imammedo@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH v2 1/1] target-i386: Fix default Hypervisor level for hypervisor-vendor=kvm.
Date: Fri, 21 Sep 2012 16:26:58 -0400	[thread overview]
Message-ID: <505CCD92.5080300@CloudSwitch.Com> (raw)
In-Reply-To: <20120921141829.GC3983@otherpad.lan.raisama.net>

On 09/21/12 10:18, Eduardo Habkost wrote:
> On Thu, Sep 20, 2012 at 04:06:27PM -0400, Don Slutz wrote:
>>  From http://lkml.indiana.edu/hypermail/linux/kernel/1205.0/00100.html
>> EAX should be KVM_CPUID_FEATURES (0x40000001) not 0.
>>
>> Added hypervisor-vendor=kvm0 to get the older CPUID result. kvm1 selects the newer one.
> Why not just make "hypervisor-vendor=kvm" control only the hypervisor
> vendor string, and support something like "kvm-hypervisor-level=0" to
> restore the old cpuid_hv_level=0 behavior?
   -cpu host,hypervisor-vendor=kvm,hypervisor-level=0

  Does this.
>
> This is similar to the kvmclock case: it would allow us to make
> "hypervisor-vendor=kvm" use saner values as default, but letting old
> machine-types to override it for compatibility if required.
Right now since I am using env->cpuid_hv_level == 0 as a flag. This 
means that:

   -cpu host,hypervisor-level=0,hypervisor-vendor=kvm

   -cpu host,hypervisor-vendor=kvm,hypervisor-level=0

end up with different CPUID data (Which I do not like). I will fix this in the next round.

Did you want me to drop kvm0 and kvm1?
    -Don

[...]

  reply	other threads:[~2012-09-21 20:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-20 20:06 [Qemu-devel] [PATCH v2 0/1] target-i386: Fix default Hypervisor level for kvm Don Slutz
2012-09-20 20:06 ` [Qemu-devel] [PATCH v2 1/1] target-i386: Fix default Hypervisor level for hypervisor-vendor=kvm Don Slutz
2012-09-21 14:18   ` Eduardo Habkost
2012-09-21 20:26     ` Don Slutz [this message]
2012-09-21 20:49       ` Eduardo Habkost
2012-09-21 21:28         ` Don Slutz
2012-09-21 21:53           ` Eduardo Habkost
2012-09-22  3:26             ` Don Slutz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=505CCD92.5080300@CloudSwitch.Com \
    --to=don@cloudswitch.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).