From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF9oT-0007aS-J7 for qemu-devel@nongnu.org; Fri, 21 Sep 2012 16:27:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TF9oS-0001mR-Iu for qemu-devel@nongnu.org; Fri, 21 Sep 2012 16:27:01 -0400 Received: from hub021-nj-3.exch021.serverdata.net ([206.225.164.218]:46362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF9oS-0001mN-FI for qemu-devel@nongnu.org; Fri, 21 Sep 2012 16:27:00 -0400 Message-ID: <505CCD92.5080300@CloudSwitch.Com> Date: Fri, 21 Sep 2012 16:26:58 -0400 From: Don Slutz MIME-Version: 1.0 References: <1348171587-23725-1-git-send-email-Don@CloudSwitch.com> <1348171587-23725-2-git-send-email-Don@CloudSwitch.com> <20120921141829.GC3983@otherpad.lan.raisama.net> In-Reply-To: <20120921141829.GC3983@otherpad.lan.raisama.net> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/1] target-i386: Fix default Hypervisor level for hypervisor-vendor=kvm. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: imammedo@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org On 09/21/12 10:18, Eduardo Habkost wrote: > On Thu, Sep 20, 2012 at 04:06:27PM -0400, Don Slutz wrote: >> From http://lkml.indiana.edu/hypermail/linux/kernel/1205.0/00100.html >> EAX should be KVM_CPUID_FEATURES (0x40000001) not 0. >> >> Added hypervisor-vendor=kvm0 to get the older CPUID result. kvm1 selects the newer one. > Why not just make "hypervisor-vendor=kvm" control only the hypervisor > vendor string, and support something like "kvm-hypervisor-level=0" to > restore the old cpuid_hv_level=0 behavior? -cpu host,hypervisor-vendor=kvm,hypervisor-level=0 Does this. > > This is similar to the kvmclock case: it would allow us to make > "hypervisor-vendor=kvm" use saner values as default, but letting old > machine-types to override it for compatibility if required. Right now since I am using env->cpuid_hv_level == 0 as a flag. This means that: -cpu host,hypervisor-level=0,hypervisor-vendor=kvm -cpu host,hypervisor-vendor=kvm,hypervisor-level=0 end up with different CPUID data (Which I do not like). I will fix this in the next round. Did you want me to drop kvm0 and kvm1? -Don [...]