From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFAWa-0002B1-1j for qemu-devel@nongnu.org; Fri, 21 Sep 2012 17:12:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFAWY-0006D7-UH for qemu-devel@nongnu.org; Fri, 21 Sep 2012 17:12:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10627) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFAWY-0006Cx-Ls for qemu-devel@nongnu.org; Fri, 21 Sep 2012 17:12:34 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8LLCX4D016472 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Sep 2012 17:12:33 -0400 Message-ID: <505CD83F.6000604@redhat.com> Date: Fri, 21 Sep 2012 15:12:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348236500-2565-1-git-send-email-quintela@redhat.com> <1348236500-2565-12-git-send-email-quintela@redhat.com> <505C890A.1080400@redhat.com> In-Reply-To: <505C890A.1080400@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig9F6B49409EFAECEFFC278BFD" Subject: Re: [Qemu-devel] [PATCH 11/14] buffered_file: don't flush on put buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel , Juan Quintela This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9F6B49409EFAECEFFC278BFD Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 09/21/2012 09:34 AM, Paolo Bonzini wrote: > Il 21/09/2012 16:08, Juan Quintela ha scritto: >> We call buffered_put_buffer with iothread held, and buffered_flush() d= oes >> synchronous writes. We only want to do the synchronous writes outside= =2E >> >=20 > This means that the buffer can grow to up to s->xfer_limit bytes. > Perhaps you want to make the granularity (currently fixed to 100ms) a > bit smaller, like 20-30 ms, if the bandwidth limit grows above say 100 > MB/sec? This can be done on top of this series however. Note that libvirt intentionally tries to raise the bandwidth as high as possible in cases where the user did not request a particular bandwidth. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig9F6B49409EFAECEFFC278BFD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQXNhAAAoJEKeha0olJ0NqgGEH/ifRTvfE4ChrXByPvvVy/61S kznoZ3g63ZnU0GRex810d964euW7D18CT3fdmp+ox8U8gg5dQOviVA/vSvGB7cYQ G50kfazNoWyoObCO7/9Cz50L62aTWvpL9WM1czprNEcHeXYnmwIMdWJaTFZbzh1E KbDKbpvHW7tW1A8m7KYJV9oLAbW0X6VlqKUh/lKnQ7bHJ5w76Bx/rXABfpitletq FEAqmLE1StN/+h3O739QdxJjzvqmwT87iFjU2Y13zSVs+04vXvMXQq27tz/MoYDH 9iMI1GYXg6yuwWEmA6jBileJsmFnTySfaZkyOP2xcKNoCMgzh8kEqOBA0cpI5FE= =m16b -----END PGP SIGNATURE----- --------------enig9F6B49409EFAECEFFC278BFD--