From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFBJw-00047u-LG for qemu-devel@nongnu.org; Fri, 21 Sep 2012 18:03:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFBJv-0007Gg-D0 for qemu-devel@nongnu.org; Fri, 21 Sep 2012 18:03:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFBJv-0007Gc-3z for qemu-devel@nongnu.org; Fri, 21 Sep 2012 18:03:35 -0400 Message-ID: <505CE42E.4030402@redhat.com> Date: Fri, 21 Sep 2012 16:03:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348226255-4226-1-git-send-email-vasilis.liaskovitis@profitbricks.com> <1348226255-4226-12-git-send-email-vasilis.liaskovitis@profitbricks.com> In-Reply-To: <1348226255-4226-12-git-send-email-vasilis.liaskovitis@profitbricks.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigAE86778636AD674DC9ED9139" Subject: Re: [Qemu-devel] [RFC PATCH v3 11/19] Implement qmp and hmp commands for notification lists List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vasilis Liaskovitis Cc: kvm@vger.kernel.org, seabios@seabios.org, qemu-devel@nongnu.org, gleb@redhat.com, blauwirbel@gmail.com, kevin@koconnor.net, avi@redhat.com, anthony@codemonkey.ws, imammedo@redhat.com, kraxel@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigAE86778636AD674DC9ED9139 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/21/2012 05:17 AM, Vasilis Liaskovitis wrote: > Guest can respond to ACPI hotplug events e.g. with _EJ or _OST method. > This patch implements a tail queue to store guest notifications for mem= ory > hot-add and hot-remove requests. >=20 > Guest responses for memory hotplug command on a per-dimm basis can be d= etected > with the new hmp command "info memhp" or the new qmp command "query-mem= hp" Naming doesn't match the QMP code. > Examples: >=20 > (qemu) device_add dimm,id=3Dram0 >=20 > These notification items should probably be part of migration state (no= t yet > implemented). In the case of libvirt driving migration, you already said in 10/19 that libvirt has to start the destination with the populated=3Don|off fields correct for each dimm according to the state it was in at the time the host started the update. Can the host hot unplug memory after migration has started? > + > +## > +# @MemHpInfo: > +# > +# Information about status of a memory hotplug command > +# > +# @dimm: the Dimm associated with the result > +# > +# @result: the result of the hotplug command > +# > +# Since: 1.3 > +# > +## > +{ 'type': 'MemHpInfo', > + 'data': {'dimm': 'str', 'request': 'str', 'result': 'str'} } Should 'result' be a bool (true for success, false for still pending) or an enum, instead of a free-form string? Likewise, isn't 'request' going to be exactly one of two values (plug or unplug)? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigAE86778636AD674DC9ED9139 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQXOQuAAoJEKeha0olJ0NqEq8H/1q9dqGlFsNUMHjSskcD0NXf u9rouiW8NPP58CiL0Q1o8sqyaip89+1Zs6E7kS2kYOJ6VfuhfG/yXcz3DJ3eulAu OowKSgTF7xcmzqY6HWz1v+L606ibqltqT5jIaEHsjyzajPgIZZ9QzRk94u5V1Z2E WrisVnkTznBFdMiqirA+NbmcaUJYxvkLuu1fvahOprzjHk38022qVX+7jB3iekw1 Dh/9tkHwfR7B2PTq1RA5a2FEvU+mYqlSY4sW1658MY/CrrkObuETptMTjRV3sLFF snPOH6SsCKKnzvPc1BKAvxoXeOABHIW6vevzqVMTN4Kg3oVmobcXrAkoi6qR4jY= =AFLS -----END PGP SIGNATURE----- --------------enigAE86778636AD674DC9ED9139--