From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 10/10] tcg/optimize: add constant folding for deposit
Date: Sat, 22 Sep 2012 05:45:40 -0700 [thread overview]
Message-ID: <505DB2F4.2020900@twiddle.net> (raw)
In-Reply-To: <20120922094105.GD23250@ohm.aurel32.net>
On 2012-09-22 02:41, Aurelien Jarno wrote:
> On Fri, Sep 21, 2012 at 04:22:53PM -0700, Richard Henderson wrote:
>> On 09/21/2012 12:43 PM, Aurelien Jarno wrote:
>>> + tmp = ((1ull << args[4]) - 1);
>>> + tmp = (temps[args[1]].val & ~(tmp << args[3]))
>>> + | ((temps[args[2]].val & tmp) << args[3]);
>>> + tcg_opt_gen_movi(gen_args, args[0], tmp);
>>
>> We do have a deposit64 function in bitops.h, fwiw.
>>
>> Though, really, bitops.h has some crappy functions in it that are
>> redundant with the better functions in host-utils.h...
>>
>
> Is there a reason that bitops.h is not used from tcg/*, while
> host-utils.h is? Licensing issue maybe (bitops.h is LGPL, host-utils.h
> is BSD like).
I assumed without looking that bitops.h is newer.
r~
next prev parent reply other threads:[~2012-09-22 12:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 19:43 [Qemu-devel] [PATCH v2 00/10] tcg/optimize: rework copy propagation Aurelien Jarno
2012-09-21 19:43 ` [Qemu-devel] [PATCH v2 01/10] tcg/optimize: remove TCG_TEMP_ANY Aurelien Jarno
2012-09-21 19:43 ` [Qemu-devel] [PATCH v2 02/10] tcg/optimize: check types in copy propagation Aurelien Jarno
2012-09-21 19:43 ` [Qemu-devel] [PATCH v2 03/10] tcg/optimize: rework copy progagation Aurelien Jarno
2012-09-21 19:43 ` [Qemu-devel] [PATCH v2 04/10] tcg/optimize: do copy propagation for all operations Aurelien Jarno
2012-09-21 19:43 ` [Qemu-devel] [PATCH v2 05/10] tcg/optimize: optimize "op r, a, a => mov r, a" Aurelien Jarno
2012-09-21 19:43 ` [Qemu-devel] [PATCH v2 06/10] tcg/optimize: optimize "op r, a, a => movi r, 0" Aurelien Jarno
2012-09-21 19:43 ` [Qemu-devel] [PATCH v2 07/10] tcg/optimize: further optimize brcond/movcond/setcond Aurelien Jarno
2012-09-21 23:17 ` Richard Henderson
2012-09-22 9:35 ` Aurelien Jarno
2012-09-22 12:46 ` Richard Henderson
2012-09-21 19:43 ` [Qemu-devel] [PATCH v2 08/10] tcg/optimize: prefer the "op a, a, b" form for commutative ops Aurelien Jarno
2012-09-21 19:43 ` [Qemu-devel] [PATCH v2 09/10] tcg: remove #ifdef #endif around TCGOpcode tests Aurelien Jarno
2012-09-21 19:43 ` [Qemu-devel] [PATCH v2 10/10] tcg/optimize: add constant folding for deposit Aurelien Jarno
2012-09-21 23:22 ` Richard Henderson
2012-09-22 9:41 ` Aurelien Jarno
2012-09-22 12:45 ` Richard Henderson [this message]
2012-09-22 14:41 ` Blue Swirl
2012-09-21 23:23 ` [Qemu-devel] [PATCH v2 00/10] tcg/optimize: rework copy propagation Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505DB2F4.2020900@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).