From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFP65-0001RI-82 for qemu-devel@nongnu.org; Sat, 22 Sep 2012 08:46:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFP64-0000PH-BX for qemu-devel@nongnu.org; Sat, 22 Sep 2012 08:46:13 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:36232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFP64-0000PB-54 for qemu-devel@nongnu.org; Sat, 22 Sep 2012 08:46:12 -0400 Received: by pbbrp12 with SMTP id rp12so9581350pbb.4 for ; Sat, 22 Sep 2012 05:46:11 -0700 (PDT) Sender: Richard Henderson Message-ID: <505DB318.4080905@twiddle.net> Date: Sat, 22 Sep 2012 05:46:16 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1348256598-8146-1-git-send-email-aurelien@aurel32.net> <1348256598-8146-8-git-send-email-aurelien@aurel32.net> <505CF574.80901@twiddle.net> <20120922093531.GC23250@ohm.aurel32.net> In-Reply-To: <20120922093531.GC23250@ohm.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 07/10] tcg/optimize: further optimize brcond/movcond/setcond List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 2012-09-22 02:35, Aurelien Jarno wrote: > On Fri, Sep 21, 2012 at 04:17:08PM -0700, Richard Henderson wrote: >> On 09/21/2012 12:43 PM, Aurelien Jarno wrote: >>> +/* Return 2 if the condition can't be simplified, and the result >>> + of the condition (0 or 1) if it can */ >> >> Ok as-is. But I'd bike-shed the "fail" return to -1. >> > > I have done it that way, as tmp is an unsigned value, and I didn't want > to add another one. But that can be changed. > Fair enough. Green it is for the shed. r~