From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53799)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1TFQC6-00071h-ET
	for qemu-devel@nongnu.org; Sat, 22 Sep 2012 09:56:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1TFQC5-0007gV-2d
	for qemu-devel@nongnu.org; Sat, 22 Sep 2012 09:56:30 -0400
Received: from mout.web.de ([212.227.17.12]:50804)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1TFQC4-0007gA-Pc
	for qemu-devel@nongnu.org; Sat, 22 Sep 2012 09:56:29 -0400
Message-ID: <505DC388.9060505@web.de>
Date: Sat, 22 Sep 2012 15:56:24 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <505C9E59.2040308@suse.de>
	<1348314355-10992-1-git-send-email-andreas.faerber@web.de>
	<CAFEAcA97DWN0aqBo8YPLwsXJUxY=Z4tVEhsK79CojSL4EP7Emg@mail.gmail.com>
In-Reply-To: <CAFEAcA97DWN0aqBo8YPLwsXJUxY=Z4tVEhsK79CojSL4EP7Emg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC v2 1/2] target-arm: Prepare support for
	Cortex-R4
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: giancarlo.asnaghi@st.com, qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>

Am 22.09.2012 15:05, schrieb Peter Maydell:
> On 22 September 2012 12:45, Andreas Färber <andreas.faerber@web.de> wrote:
>> +static void cortex_r4_initfn(Object *obj)
>> +{
>> +    ARMCPU *cpu = ARM_CPU(obj);
>> +    set_feature(&cpu->env, ARM_FEATURE_V7);
>> +    set_feature(&cpu->env, ARM_FEATURE_THUMB_DIV);
>> +    set_feature(&cpu->env, ARM_FEATURE_MPU);
> 
> This will trip the assert in register_cp_regs_for_features():

Thanks for the pointer. This rebased version is only compile-tested and
is provided mainly for the ST guys to build upon, during my absence.

>     if (arm_feature(env, ARM_FEATURE_MPU)) {
>         /* These are the MPU registers prior to PMSAv6. Any new
>          * PMSA core later than the ARM946 will require that we
>          * implement the PMSAv6 or PMSAv7 registers, which are
>          * completely different.
>          */
>         assert(!arm_feature(env, ARM_FEATURE_V6));
> 
> ...indicating that R4 support is more work than is contained
> in this patch :-)

...which confirms what I stated in the message this is threaded to, and
is reflected by "prepare". :)

Same for VFPv3-D16 in the second RFC patch (which used to "add" to
cortex-r4, now should've been updated to "prepare" as well).

And of course the Cortex-R4's lock-step mode that seems to make it so
interesting for automotive customers.

/-F