From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] hw/xics: Fix one-bit signed bitfields
Date: Sat, 22 Sep 2012 23:34:47 +0200 [thread overview]
Message-ID: <505E2EF7.5050207@weilnetz.de> (raw)
In-Reply-To: <CAFEAcA-r8N+vzqDfLB4592W6V+Mt=ko=nyqp3syXSxOLBz4OkQ@mail.gmail.com>
Am 04.09.2012 22:53, schrieb Peter Maydell:
> On 4 September 2012 21:30, Stefan Weil<sw@weilnetz.de> wrote:
>> Report from smatch:
>>
>> xics.c:169:19: error: dubious one-bit signed bitfield
>> xics.c:170:15: error: dubious one-bit signed bitfield
>> xics.c:171:19: error: dubious one-bit signed bitfield
>> xics.c:172:25: error: dubious one-bit signed bitfield
>>
>> Instead of replacing 'int' by 'unsigned', 'bool' was used because
>> all 4 values are boolean values.
>>
>> Replacing 0 and 1 in the assignments by false and true
>> looks better for those boolean values.
>
> If we're changing this we should just drop the bitfield usage
> entirely and use plain bool, I think.
>
> -- PMM
David, could you please review the patch and Peter's suggestion?
See also http://patchwork.ozlabs.org/patch/181671/
Thanks,
Stefan Weil
prev parent reply other threads:[~2012-09-22 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 20:30 [Qemu-devel] [PATCH] hw/xics: Fix one-bit signed bitfields Stefan Weil
2012-09-04 20:53 ` Peter Maydell
2012-09-22 21:34 ` Stefan Weil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505E2EF7.5050207@weilnetz.de \
--to=sw@weilnetz.de \
--cc=david@gibson.dropbear.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).