From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55304)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1TFiyN-0002ji-BT
	for qemu-devel@nongnu.org; Sun, 23 Sep 2012 05:59:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1TFiyM-0006np-DU
	for qemu-devel@nongnu.org; Sun, 23 Sep 2012 05:59:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32374)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1TFiyM-0006nj-5U
	for qemu-devel@nongnu.org; Sun, 23 Sep 2012 05:59:34 -0400
Message-ID: <505EDF0C.1050500@redhat.com>
Date: Sun, 23 Sep 2012 12:06:04 +0200
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1348155487-9119-1-git-send-email-hdegoede@redhat.com>
	<CAAu8pHt8WEq_qMZs44NHwRj1_f0Fr7OvKtuWHfKxF76QApzd7A@mail.gmail.com>
In-Reply-To: <CAAu8pHt8WEq_qMZs44NHwRj1_f0Fr7OvKtuWHfKxF76QApzd7A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] ehci: Fix interrupt packet MULT handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: shawn.starr@rogers.com, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

Hi,

Sorry.

On 09/22/2012 03:16 PM, Blue Swirl wrote:
> On Thu, Sep 20, 2012 at 3:38 PM, Hans de Goede <hdegoede@redhat.com> wrote:

<snip>

>> @@ -1837,6 +1838,10 @@ static EHCIQueue *ehci_state_fetchqh(EHCIState *ehci, int async)
>>       }
>>       q->qh = qh;
>>
>> +    q->transact_ctr = get_field(q->qh.epcap, QH_EPCAP_MULT);
>> +    if (q->transact_ctr == 0) /* Guest bug in some versions of windows */
>> +        q->transact_ctr = 4;
>
> Missing braces, please use checkpatch.pl.
>

Oops, Gerd since this is already in your tree, can you fix this, or do you
want a new fixed version ?

Regards,

Hans