From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE34C433E0 for ; Wed, 20 Jan 2021 14:59:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB5D323383 for ; Wed, 20 Jan 2021 14:59:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB5D323383 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2Exf-0001q7-Kr for qemu-devel@archiver.kernel.org; Wed, 20 Jan 2021 09:59:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2EwU-0001Gb-8p for qemu-devel@nongnu.org; Wed, 20 Jan 2021 09:58:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2EwR-0000o9-D5 for qemu-devel@nongnu.org; Wed, 20 Jan 2021 09:58:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611154717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qh+O3F1pRG/vLNskRWeYWMnW3IOoWFMXx2o9tG0imGw=; b=UBb5MVHk7saTH0usKN/PJpOqxzq9V+UD2n1Mo6mBrQGUS7rMEYEuZesNqh0GUgyrIxPLh/ Q1/i+cdih9jJzutdnIRsNhSKCosqJ7rfMSPxfVHtaYNs622QRHddcVEBxs70F+YDNlspgz c0zf0z3B60OyMAiXDxEIF9oab083c/A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-187-2OCWDjG6NwO-QW2BmwHmJA-1; Wed, 20 Jan 2021 09:58:34 -0500 X-MC-Unique: 2OCWDjG6NwO-QW2BmwHmJA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EB9C2806663; Wed, 20 Jan 2021 14:58:32 +0000 (UTC) Received: from [10.3.113.116] (ovpn-113-116.phx2.redhat.com [10.3.113.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6DD4D60C74; Wed, 20 Jan 2021 14:58:29 +0000 (UTC) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210118170308.282442-1-philmd@redhat.com> <20210118170308.282442-2-philmd@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Subject: Re: [RFC PATCH 1/2] scsi/utils: Add INVALID_PARAM_VALUE sense code definition Message-ID: <505a6e2f-a07b-5e1f-a6d0-3d32b6388bb3@redhat.com> Date: Wed, 20 Jan 2021 08:58:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210118170308.282442-2-philmd@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.167, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.094, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Paolo Bonzini , Gerd Hoffmann , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/18/21 11:03 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/scsi/utils.h | 2 ++ > scsi/utils.c | 5 +++++ > 2 files changed, 7 insertions(+) > > diff --git a/include/scsi/utils.h b/include/scsi/utils.h > index fbc55882799..096489c6cd1 100644 > --- a/include/scsi/utils.h > +++ b/include/scsi/utils.h > @@ -57,6 +57,8 @@ extern const struct SCSISense sense_code_LBA_OUT_OF_RANGE; > extern const struct SCSISense sense_code_INVALID_FIELD; > /* Illegal request, Invalid field in parameter list */ > extern const struct SCSISense sense_code_INVALID_PARAM; > +/* Illegal request, Invalid value in parameter list */ > +extern const struct SCSISense sense_code_INVALID_PARAM_VALUE; > /* Illegal request, Parameter list length error */ > extern const struct SCSISense sense_code_INVALID_PARAM_LEN; > /* Illegal request, LUN not supported */ Pre-existing: the term 'illegal' is suspect in computer science (the code isn't breaking any laws); I prefer 'invalid'. But that's a pet peeve of mine, and not something you need to change here. > diff --git a/scsi/utils.c b/scsi/utils.c > index b37c2830148..793c3a6b9c9 100644 > --- a/scsi/utils.c > +++ b/scsi/utils.c > @@ -197,6 +197,11 @@ const struct SCSISense sense_code_INVALID_PARAM = { > .key = ILLEGAL_REQUEST, .asc = 0x26, .ascq = 0x00 > }; > > +/* Illegal request, Invalid value in parameter list */ > +const struct SCSISense sense_code_INVALID_PARAM_VALUE = { > + .key = ILLEGAL_REQUEST, .asc = 0x26, .ascq = 0x01 > +}; > + > /* Illegal request, Parameter list length error */ > const struct SCSISense sense_code_INVALID_PARAM_LEN = { > .key = ILLEGAL_REQUEST, .asc = 0x1a, .ascq = 0x00 > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org