From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TG6JN-0000aA-01 for qemu-devel@nongnu.org; Mon, 24 Sep 2012 06:54:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TG6JH-000229-7c for qemu-devel@nongnu.org; Mon, 24 Sep 2012 06:54:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TG6JG-000223-VZ for qemu-devel@nongnu.org; Mon, 24 Sep 2012 06:54:43 -0400 Message-ID: <5060308C.1060402@redhat.com> Date: Mon, 24 Sep 2012 12:06:04 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1348411747-29804-1-git-send-email-owasserm@redhat.com> <1348411747-29804-5-git-send-email-owasserm@redhat.com> <87d31bsqj4.fsf@blackfin.pond.sub.org> <50602EC8.5080609@redhat.com> In-Reply-To: <50602EC8.5080609@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 4/4] Clear handler only for valid fd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: kwolf@redhat.com, aliguori@us.ibm.com, akong@redhat.com, mdroth@linux.vnet.ibm.com, quintela@redhat.com, mst@redhat.com, Markus Armbruster , qemu-devel@nongnu.org, lcapitulino@redhat.com Il 24/09/2012 11:58, Orit Wasserman ha scritto: >>> >> if (s->fd != -1) { >>> >> + qemu_set_fd_handler2(s->fd, NULL, NULL, NULL, NULL); >>> >> close(s->fd); >>> >> s->fd = -1; >>> >> } >> > >> > As far as I can see, qemu_set_fd_handler2() treats invalid file >> > descriptor -1 just like any other. If it's in io_handlers, it gets >> > deleted, else it's a nop. Thus, the old code works. > Not any more, there was an assert(fd >=0) added in commit bbdd2ad0814ea0911076419ea21b7957505cf1cc > recently. > >> > I'm not sufficiently familiar with the migration code to judge whether >> > moving the handler reset down is safe. >> > > I can keep the call in the same location if you think it is safer. I think it's okay as you did, given how the code looks like now. I plan to make qemu_fclose take care of closing the file descriptor, but then I'll adjust the code myself. I just want this series to go in. :))) Paolo