From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TG6Jb-00015c-N5 for qemu-devel@nongnu.org; Mon, 24 Sep 2012 06:55:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TG6Ja-00029y-PX for qemu-devel@nongnu.org; Mon, 24 Sep 2012 06:55:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TG6Ja-00026e-HL for qemu-devel@nongnu.org; Mon, 24 Sep 2012 06:55:02 -0400 Message-ID: <506030DF.5020906@redhat.com> Date: Mon, 24 Sep 2012 12:07:27 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1348411747-29804-1-git-send-email-owasserm@redhat.com> <1348411747-29804-3-git-send-email-owasserm@redhat.com> <87y5jzrbke.fsf@blackfin.pond.sub.org> In-Reply-To: <87y5jzrbke.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 2/4] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, aliguori@us.ibm.com, akong@redhat.com, mst@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, Orit Wasserman , lcapitulino@redhat.com Il 24/09/2012 11:53, Markus Armbruster ha scritto: > ongoing > >> > + * @errp: set in case of an error >> > + **/ > We usually tack function comments to the function definition, not the > declaration. Matter of taste. I like it next to the definition, > because that improves the comment's chances to get updated along with > the function. Not necessarily, see main-loop.h for example. /me would like more of these... Paolo >> > +int inet_connect_opts(QemuOpts *opts, bool block, bool *in_progress, >> > + Error **errp);