From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58417)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1TG5dv-0006Bn-Rm
	for qemu-devel@nongnu.org; Mon, 24 Sep 2012 06:12:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1TG5du-0005B7-UE
	for qemu-devel@nongnu.org; Mon, 24 Sep 2012 06:11:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:31155)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1TG5du-0005B0-M0
	for qemu-devel@nongnu.org; Mon, 24 Sep 2012 06:11:58 -0400
Message-ID: <506031BB.30307@redhat.com>
Date: Mon, 24 Sep 2012 12:11:07 +0200
From: Orit Wasserman <owasserm@redhat.com>
MIME-Version: 1.0
References: <1348411747-29804-1-git-send-email-owasserm@redhat.com>
	<1348411747-29804-4-git-send-email-owasserm@redhat.com>
	<20120924101011.GA5848@redhat.com>
In-Reply-To: <20120924101011.GA5848@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 3/4] Fix address handling in
	inet_nonblocking_connect
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, mdroth@linux.vnet.ibm.com, quintela@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, akong@redhat.com

On 09/24/2012 12:10 PM, Michael S. Tsirkin wrote:
> On Sun, Sep 23, 2012 at 04:49:06PM +0200, Orit Wasserman wrote:
>> diff --git a/qemu_socket.h b/qemu_socket.h
>> index 3247fb7..da93509 100644
>> --- a/qemu_socket.h
>> +++ b/qemu_socket.h
>> @@ -38,20 +38,31 @@ void socket_set_block(int fd);
>>  void socket_set_nonblock(int fd);
>>  int send_all(int fd, const void *buf, int len1);
>>  
>> +/* callback function for nonblocking connect
>> + * vaild fd on success, negative error code on failure
> 
> typo
> 
>> + */
>> +typedef void ConnectHandler(int fd, void *opaque);
> 
> Can we rename this NonBlockingConnectHandler?
Of course.
> 
>> +
>>  /* New, ipv6-ready socket helper functions, see qemu-sockets.c */
> 
> BTW let's kill this comment.
>