From: Orit Wasserman <owasserm@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, akong@redhat.com,
mdroth@linux.vnet.ibm.com, quintela@redhat.com, mst@redhat.com,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 2/4] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect
Date: Mon, 24 Sep 2012 15:37:46 +0200 [thread overview]
Message-ID: <5060622A.2020500@redhat.com> (raw)
In-Reply-To: <506030DF.5020906@redhat.com>
On 09/24/2012 12:07 PM, Paolo Bonzini wrote:
> Il 24/09/2012 11:53, Markus Armbruster ha scritto:
>> ongoing
>>
>>>> + * @errp: set in case of an error
>>>> + **/
>> We usually tack function comments to the function definition, not the
>> declaration. Matter of taste. I like it next to the definition,
>> because that improves the comment's chances to get updated along with
>> the function.
>
> Not necessarily, see main-loop.h for example.
>
> /me would like more of these...
too late :)
>
> Paolo
>
>>>> +int inet_connect_opts(QemuOpts *opts, bool block, bool *in_progress,
>>>> + Error **errp);
>
next prev parent reply other threads:[~2012-09-24 13:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-23 14:49 [Qemu-devel] [PATCH v4 0/4] nonblocking connect address handling cleanup Orit Wasserman
2012-09-23 14:49 ` [Qemu-devel] [PATCH v4 1/4] Refactor inet_connect_opts function Orit Wasserman
2012-09-23 14:49 ` [Qemu-devel] [PATCH v4 2/4] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect Orit Wasserman
2012-09-24 9:53 ` Markus Armbruster
2012-09-24 10:07 ` Paolo Bonzini
2012-09-24 13:37 ` Orit Wasserman [this message]
2012-09-24 13:43 ` Paolo Bonzini
2012-09-23 14:49 ` [Qemu-devel] [PATCH v4 3/4] Fix address handling in inet_nonblocking_connect Orit Wasserman
2012-09-24 9:54 ` Markus Armbruster
2012-09-24 10:05 ` Amos Kong
2012-09-24 10:12 ` Orit Wasserman
[not found] ` <20120924101011.GA5848@redhat.com>
2012-09-24 10:11 ` Orit Wasserman
2012-09-23 14:49 ` [Qemu-devel] [PATCH v4 4/4] Clear handler only for valid fd Orit Wasserman
2012-09-24 9:45 ` Markus Armbruster
2012-09-24 9:58 ` Orit Wasserman
2012-09-24 10:06 ` Paolo Bonzini
2012-09-24 11:34 ` Markus Armbruster
2012-09-23 15:05 ` [Qemu-devel] [PATCH v4 0/4] nonblocking connect address handling cleanup Michael S. Tsirkin
2012-09-24 9:54 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5060622A.2020500@redhat.com \
--to=owasserm@redhat.com \
--cc=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).