From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TG8rw-0005q6-6h for qemu-devel@nongnu.org; Mon, 24 Sep 2012 09:38:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TG8rm-0005U2-UM for qemu-devel@nongnu.org; Mon, 24 Sep 2012 09:38:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TG8rm-0005Tr-Ly for qemu-devel@nongnu.org; Mon, 24 Sep 2012 09:38:30 -0400 Message-ID: <5060622A.2020500@redhat.com> Date: Mon, 24 Sep 2012 15:37:46 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1348411747-29804-1-git-send-email-owasserm@redhat.com> <1348411747-29804-3-git-send-email-owasserm@redhat.com> <87y5jzrbke.fsf@blackfin.pond.sub.org> <506030DF.5020906@redhat.com> In-Reply-To: <506030DF.5020906@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 2/4] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, aliguori@us.ibm.com, akong@redhat.com, mdroth@linux.vnet.ibm.com, quintela@redhat.com, mst@redhat.com, Markus Armbruster , qemu-devel@nongnu.org, lcapitulino@redhat.com On 09/24/2012 12:07 PM, Paolo Bonzini wrote: > Il 24/09/2012 11:53, Markus Armbruster ha scritto: >> ongoing >> >>>> + * @errp: set in case of an error >>>> + **/ >> We usually tack function comments to the function definition, not the >> declaration. Matter of taste. I like it next to the definition, >> because that improves the comment's chances to get updated along with >> the function. > > Not necessarily, see main-loop.h for example. > > /me would like more of these... too late :) > > Paolo > >>>> +int inet_connect_opts(QemuOpts *opts, bool block, bool *in_progress, >>>> + Error **errp); >