From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGAkA-0005jQ-Nu for qemu-devel@nongnu.org; Mon, 24 Sep 2012 11:38:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGAk2-00012n-Tz for qemu-devel@nongnu.org; Mon, 24 Sep 2012 11:38:46 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:61063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGAk2-00012X-Nt for qemu-devel@nongnu.org; Mon, 24 Sep 2012 11:38:38 -0400 Received: by padfb10 with SMTP id fb10so1561114pad.4 for ; Mon, 24 Sep 2012 08:38:37 -0700 (PDT) Sender: Richard Henderson Message-ID: <50607E82.8040904@twiddle.net> Date: Mon, 24 Sep 2012 08:38:42 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1348273096-1495-1-git-send-email-rth@twiddle.net> <1348273096-1495-6-git-send-email-rth@twiddle.net> <20120922195206.GA32408@ohm.aurel32.net> In-Reply-To: <20120922195206.GA32408@ohm.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/8] tcg: Implement concat*_i64 with deposit_i64 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 2012-09-22 12:52, Aurelien Jarno wrote: > On Fri, Sep 21, 2012 at 05:18:13PM -0700, Richard Henderson wrote: >> For tcg_gen_concat_i32_i64 we only use deposit if the host supports it. >> For tcg_gen_concat32_i64 even if the host does not, as we get identical >> code before and after. >> >> Note that this relies on the ANDI -> EXTU patch for the identity claim. > > I don't really get why, andi is not used in this patch. No, but tcg_gen_deposit uses andi in its fallback implementation. r~