qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Alex Barcelo <abarcelo@ac.upc.edu>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 3/7] tcg-i386: Implement movcond
Date: Mon, 24 Sep 2012 14:54:27 -0700	[thread overview]
Message-ID: <5060D693.7060601@twiddle.net> (raw)
In-Reply-To: <CAFKAgTf9rThn34VYHR+u4eEK41K90ooHDwMvMYTY2Av9xnnsYg@mail.gmail.com>

On 09/24/2012 02:37 PM, Alex Barcelo wrote:
> just finished a git-bisect and I found this... and now I do not fully
> understand why I have the problem.
> 
> To replicate the error (in a i386 machine, at least):
> $ make clean && ./configure --enable-debug && make -j && make install
> [Note: I tried both ppc and i386 targets, so doesn't seem machine-dependent]
> $ ./path/to/qemu/bin/qemu-i386 doesntmatter
> Invalid op definition for movcond_i32
> /mnt/DATA/DARCO/qemu-git/tcg/tcg.c:1170: tcg fatal error
> Aborted

Ah, right.  I only tried with -march=i686.

>> +    { INDEX_op_movcond_i32, { "r", "r", "ri", "r", "0" } },

Should be protected by 

#if TCG_TARGET_HAS_movcond_i32

If no one beats me to this, I'll submit a patch this evening.


r~

  reply	other threads:[~2012-09-24 21:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-21 17:13 [Qemu-devel] [PATCH v2 0/7] tcg: movcond Richard Henderson
2012-09-21 17:13 ` [Qemu-devel] [PATCH 1/7] tcg: Introduce movcond Richard Henderson
2012-09-21 17:13 ` [Qemu-devel] [PATCH 2/7] target-alpha: Use movcond Richard Henderson
2012-09-21 17:13 ` [Qemu-devel] [PATCH 3/7] tcg-i386: Implement movcond Richard Henderson
2012-09-24 21:37   ` Alex Barcelo
2012-09-24 21:54     ` Richard Henderson [this message]
2012-09-25 22:48       ` Aurelien Jarno
2012-09-21 17:13 ` [Qemu-devel] [PATCH 4/7] tcg: Optimize movcond for constant comparisons Richard Henderson
2012-09-21 17:13 ` [Qemu-devel] [PATCH 5/7] tcg: Optimize two-address commutative operations Richard Henderson
2012-09-21 17:13 ` [Qemu-devel] [PATCH 6/7] tcg: Streamline movcond_i64 using 32-bit arithmetic Richard Henderson
2012-09-21 21:15   ` Aurelien Jarno
2012-09-22 18:11   ` Aurelien Jarno
2012-09-21 17:13 ` [Qemu-devel] [PATCH 7/7] tcg: Streamline movcond_i64 using movcond_i32 Richard Henderson
2012-09-21 21:23   ` Aurelien Jarno
2012-09-21 22:27     ` Richard Henderson
2012-09-22  9:30       ` Aurelien Jarno
2012-09-21 18:14 ` [Qemu-devel] [PATCH v2 0/7] tcg: movcond Aurelien Jarno
2012-09-21 20:10 ` [Qemu-devel] [PATCH v2 0/7] tcg: movcond (ppc32 version) malc
2012-09-21 22:21   ` Richard Henderson
2012-09-21 22:34     ` malc
2012-09-22 14:38   ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5060D693.7060601@twiddle.net \
    --to=rth@twiddle.net \
    --cc=abarcelo@ac.upc.edu \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).