From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGKMW-0005rh-OZ for qemu-devel@nongnu.org; Mon, 24 Sep 2012 21:55:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGKMV-00051d-Qp for qemu-devel@nongnu.org; Mon, 24 Sep 2012 21:55:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGKMV-00051U-In for qemu-devel@nongnu.org; Mon, 24 Sep 2012 21:54:59 -0400 Message-ID: <50610EEA.2060008@redhat.com> Date: Tue, 25 Sep 2012 09:54:50 +0800 From: Amos Kong MIME-Version: 1.0 References: <1348485070-8190-1-git-send-email-owasserm@redhat.com> In-Reply-To: <1348485070-8190-1-git-send-email-owasserm@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/4] non-blocking connect address handling cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: kwolf@redhat.com, aliguori@us.ibm.com, mdroth@linux.vnet.ibm.com, mst@redhat.com, quintela@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com On 24/09/12 19:11, Orit Wasserman wrote: > Changes from v4: > - Rename ConnectHandler to NonBlockingConnectHandler > - move function comments to functions definitions > - move connect_state allocation to outside of the loop > - fix comments text > > Changes from v3: > - add missing parenthesis QEMU_SOCKET_RC_INPROGRESS macro > - remove "block" from dummy_opts > - remove in_progress from external API (inet_connect_opts and > inet_nonblocking_connect) > - Allocate ConnectState inside inet_connect_opts, this make the > structure internal to qemu-sockets.c > - fix migrate_fd_cleanup to handle invalid fd. > > Changes from v2: > - remove the use of getnameinfo > - remove errp for inet_connect_addr > - remove QemuOpt "block" > - fix errors in wait_for_connect > - pass ConnectState as a parameter to allow concurrent connect ops > > getaddrinfo can give us a list of addresses, but we only try to > connect to the first one. If that fails we never proceed to > the next one. This is common on desktop setups that often have ipv6 > configured but not actually working. > A simple way to reproduce the problem is migration: > for the destination use -incoming tcp:0:4444, run migrate -d tcp:localhost:4444 > migration will fail on hosts that have both IPv4 and IPV6 address for localhost. > > To fix this, refactor address resolution code and make inet_nonblocking_connect > retry connection with a different address. Reviewed-by: Amos Kong Tested-by: Amos Kong -- Amos.