From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48194)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1TGQDY-00034a-VF
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 04:10:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1TGQDR-0003bB-1w
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 04:10:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21933)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1TGQDQ-0003b4-Pw
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 04:10:00 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8P8A0rm003909
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 25 Sep 2012 04:10:00 -0400
Message-ID: <506166DE.8030802@redhat.com>
Date: Tue, 25 Sep 2012 10:10:06 +0200
From: Orit Wasserman <owasserm@redhat.com>
MIME-Version: 1.0
References: <1348217255-22441-1-git-send-email-quintela@redhat.com>
	<1348217255-22441-4-git-send-email-quintela@redhat.com>
In-Reply-To: <1348217255-22441-4-git-send-email-quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/41] migration: store end_time in a local
 variable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On 09/21/2012 11:46 AM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  migration.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/migration.c b/migration.c
> index 1edeec5..1e3f791 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -327,6 +327,7 @@ static void migrate_fd_put_ready(void *opaque)
>          migrate_fd_error(s);
>      } else if (ret == 1) {
>          int old_vm_running = runstate_is_running();
> +        int64_t end_time;
> 
>          DPRINTF("done iterating\n");
>          qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER);
> @@ -337,7 +338,8 @@ static void migrate_fd_put_ready(void *opaque)
>          } else {
>              migrate_fd_completed(s);
>          }
> -        s->total_time = qemu_get_clock_ms(rt_clock) - s->total_time;
> +        end_time = qemu_get_clock_ms(rt_clock);
> +        s->total_time = end_time - s->total_time;
>          if (s->state != MIG_STATE_COMPLETED) {
>              if (old_vm_running) {
>                  vm_start();
> 

Reviewed-by: Orit Wasserman <owasserm@redhat.com>