From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGZSy-0002mf-Lp for qemu-devel@nongnu.org; Tue, 25 Sep 2012 14:02:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGZSq-0007TH-Ae for qemu-devel@nongnu.org; Tue, 25 Sep 2012 14:02:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGZSq-0007T2-2k for qemu-devel@nongnu.org; Tue, 25 Sep 2012 14:02:32 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8PI2VG3022083 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 25 Sep 2012 14:02:31 -0400 Message-ID: <5061F1AD.3080100@redhat.com> Date: Tue, 25 Sep 2012 12:02:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <9eef87356756c601e46d2ecb5f42d0c0bedf6ca3.1348589526.git.jcody@redhat.com> In-Reply-To: <9eef87356756c601e46d2ecb5f42d0c0bedf6ca3.1348589526.git.jcody@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig6096AFEB48FF2D5CECA416CA" Subject: Re: [Qemu-devel] [PATCH v2 6/7] qemu-iotests: add initial tests for live block commit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6096AFEB48FF2D5CECA416CA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/25/2012 10:29 AM, Jeff Cody wrote: > Derived from the streaming test cases (030), this adds the > following tests: >=20 > 1. For the following image chain, commit [mid] into [backing], > and use qemu-io to verify [backing] has its original data, as > well as the data from [mid] >=20 > [backing] <-- [mid] <-- [test] >=20 > 2. Verifies that 'block-commit' with the 'speed' parameter sets the > speed parameter, as reported by 'query-block-jobs' >=20 > 3. Verifies that a bogus 'device' parameter to 'block-commit' > results in error I think you are missing a test; you should also verify that: { "command":"block-commit", "arguments":{ "device":"drive0", "base":"mid", "top":"backing" } } properly fails, since 'mid' is not a backing file of 'backing'. I saw code in patch 1/7 that bdrv_drop_intermediate() should detect the situation, but I'm not confident enough in my reading of patch 2/7 to know if that detection point was early enough, or whether the coroutine stuff in 2/7 ends up corrupting 'mid' prior to failure. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig6096AFEB48FF2D5CECA416CA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQYfGwAAoJEKeha0olJ0NqzUYIAKnj+dsUNitd7UymSZYy1gEa alY6jyrOXgYnn83BhDW4exoq7gHlCsbGMcPjxu0xGH95lwnRRRhqHe+Vhy2ZaFs2 TeXLlk9UR0MIsQ/1lY+cZ2Qe6gbo5+sdHU62iIWRESqHN/mbz9i9x8osYO5XEXTc 5keWOe6U+i7BGnlr3XYRBTKbCCp4al9x5c2THUPt6FYUKsJJTqyu3V366FeEs0ip QBXGgczwTShtEcqONyrk61nnqGBD2lgp4BJcQV7VEJ8aIEco19TiO+buQF1I8rEX AFKaHid4G9IxC9el0SPjtR6rmOP/cYWXZvNwE6rzmM8oyoMjdc+9qN8OatEahdo= =QlKe -----END PGP SIGNATURE----- --------------enig6096AFEB48FF2D5CECA416CA--