From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGaGR-0007pW-SS for qemu-devel@nongnu.org; Tue, 25 Sep 2012 14:53:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGaGQ-0003bb-V8 for qemu-devel@nongnu.org; Tue, 25 Sep 2012 14:53:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46251) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGaGQ-0003bR-MX for qemu-devel@nongnu.org; Tue, 25 Sep 2012 14:53:46 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8PIrkSW009758 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 25 Sep 2012 14:53:46 -0400 Message-ID: <5061FDB8.9000205@redhat.com> Date: Tue, 25 Sep 2012 14:53:44 -0400 From: Jeff Cody MIME-Version: 1.0 References: <9eef87356756c601e46d2ecb5f42d0c0bedf6ca3.1348589526.git.jcody@redhat.com> <5061F1AD.3080100@redhat.com> In-Reply-To: <5061F1AD.3080100@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 6/7] qemu-iotests: add initial tests for live block commit Reply-To: jcody@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org On 09/25/2012 02:02 PM, Eric Blake wrote: > On 09/25/2012 10:29 AM, Jeff Cody wrote: >> Derived from the streaming test cases (030), this adds the >> following tests: >> >> 1. For the following image chain, commit [mid] into [backing], >> and use qemu-io to verify [backing] has its original data, as >> well as the data from [mid] >> >> [backing] <-- [mid] <-- [test] >> >> 2. Verifies that 'block-commit' with the 'speed' parameter sets the >> speed parameter, as reported by 'query-block-jobs' >> >> 3. Verifies that a bogus 'device' parameter to 'block-commit' >> results in error > > I think you are missing a test; you should also verify that: > > { "command":"block-commit", "arguments":{ > "device":"drive0", "base":"mid", "top":"backing" } } > > properly fails, since 'mid' is not a backing file of 'backing'. I saw > code in patch 1/7 that bdrv_drop_intermediate() should detect the > situation, but I'm not confident enough in my reading of patch 2/7 to > know if that detection point was early enough, or whether the coroutine > stuff in 2/7 ends up corrupting 'mid' prior to failure. > Good idea. This seems like a good test to have in place.