From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGaRh-00046O-Ip for qemu-devel@nongnu.org; Tue, 25 Sep 2012 15:05:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGaRc-0008K5-Kr for qemu-devel@nongnu.org; Tue, 25 Sep 2012 15:05:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51489) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGaRc-0008Ju-C6 for qemu-devel@nongnu.org; Tue, 25 Sep 2012 15:05:20 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8PJ5JIW011377 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 25 Sep 2012 15:05:19 -0400 Message-ID: <5062006D.2090004@redhat.com> Date: Tue, 25 Sep 2012 13:05:17 -0600 From: Eric Blake MIME-Version: 1.0 References: <1efc2c8c9b7c215b787507afa5a34c0175f7f4f0.1348589526.git.jcody@redhat.com> <5061F41F.4080502@redhat.com> <5061FEC7.7060709@redhat.com> In-Reply-To: <5061FEC7.7060709@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig863EBE9794EE8E8E9EB1A269" Subject: Re: [Qemu-devel] [PATCH v2 2/7] block: add live block commit functionality List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: jcody@redhat.com Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig863EBE9794EE8E8E9EB1A269 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/25/2012 12:58 PM, Jeff Cody wrote: > On 09/25/2012 02:12 PM, Eric Blake wrote: >> On 09/25/2012 10:29 AM, Jeff Cody wrote: >>> This adds the live commit coroutine. This iteration focuses on the >>> commit only below the active layer, and not the active layer itself. >>> >> I think you are missing a check here that base is on the backing chain= >> of top. See also my comments to 5/7. >> >=20 > Did you mean your comments on 6/7 (or am I missing an email)? Shoot. You're right, and I messed myself up by reviewing out of order :)= >=20 > This does get partially validated in patch 5/7, in the > qmp_block_commit() handler - both base and top are verified to be in th= e > chain 'bs'. What is not validated, however, is that you did not swap > your 'top' and 'base' arguments. I'll add a check here for that, to > make sure that base is reachable from overlay_bs. At any rate, it sounds like I got my point across, in spite of myself. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig863EBE9794EE8E8E9EB1A269 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQYgBtAAoJEKeha0olJ0NqaBsH/RQnkl5I/wcT+DyD8JDJfu2e e8qOD8N5TAwOVBCcd8eyzYaPkpSMdjli+z0S/gW7povwqCXB/EuCsjMNbEnrJ61t z+6UJPuo/p/1K6Kwkc4Y1MXpUbe7k0NSsq6PQNLIBFd/MkxuLKeH4FC7sH6pepLx SnGWL/CuU7RpEsB3vZIBB2X4teYXCNgJW/vTYDEEGGyoIBqsj4RsjivrE2RaOh9H u/+CGvDP+C+P18cAVqLpHv+yFhPzdl5EADuF4bncUZs8xJKUVUTry6jnMxDutzye eNBGNWON1JFYULd+oK7gSsjZ0M9kS4CqFA5FqsiWxifabSjQnhqGvoYOcOHOQFE= =NMNm -----END PGP SIGNATURE----- --------------enig863EBE9794EE8E8E9EB1A269--