From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGaZO-00060M-MQ for qemu-devel@nongnu.org; Tue, 25 Sep 2012 15:13:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGaZN-00034D-Jo for qemu-devel@nongnu.org; Tue, 25 Sep 2012 15:13:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGaZN-000345-A8 for qemu-devel@nongnu.org; Tue, 25 Sep 2012 15:13:21 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8PJDKUM016338 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 25 Sep 2012 15:13:20 -0400 Message-ID: <5062024C.9050603@redhat.com> Date: Tue, 25 Sep 2012 13:13:16 -0600 From: Eric Blake MIME-Version: 1.0 References: <26a2d4bf59b66b5b898ad5cbc2ac939cbd5ec255.1348589526.git.jcody@redhat.com> In-Reply-To: <26a2d4bf59b66b5b898ad5cbc2ac939cbd5ec255.1348589526.git.jcody@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig15B56048E5281EA736BD29E7" Subject: Re: [Qemu-devel] [PATCH v2 4/7] block: helper function, to find the base image of a chain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig15B56048E5281EA736BD29E7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/25/2012 10:29 AM, Jeff Cody wrote: > This is a simple helper function, that will return the base image > of a given image chain. >=20 > Signed-off-by: Jeff Cody > --- > block.c | 16 ++++++++++++++++ > block.h | 1 + > 2 files changed, 17 insertions(+) Bikeshed question: Any reason patch 1/7 adds two helper functions, and patch 4/7 adds a third? Perhaps it would be worth squashing all three into one commit, or else having three commits, one per helper? But there's no point in repainting things now, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig15B56048E5281EA736BD29E7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQYgJMAAoJEKeha0olJ0NqduAIAKu6/6SVX+sHzOwNF5kiP0q9 wIlgxXSq3mOzYQDxYa3+Rmw0HDsHajEwJZzNjyatHz9cam9Fqi1p/aPq8hN2/q72 HUzz/VxtLiDXZiRIW7HKpwfBk6n1ZoK7uj//lvDj6rf1PIcgnMC3lTaBiV57z783 r4eFchCt1A25riF6P/9jD/MoGG0LjFBPKh0GKEE4wlc3ywHDBccTQIdnwvdWASVt LuUFOPGhLBIgf256jgliR7IQXauRtMWpW9JNXd0JIQ7tbAgCWlFSBxrofRPtEyxg 0uTGupr7dt1Rux5ALxS5RLVT9kB5/6nLzhQG5ZMZOO949jom4tz7Nh3HnwDYbO8= =awvg -----END PGP SIGNATURE----- --------------enig15B56048E5281EA736BD29E7--