From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGb4V-00061r-Uo for qemu-devel@nongnu.org; Tue, 25 Sep 2012 15:45:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGb4V-0006om-2F for qemu-devel@nongnu.org; Tue, 25 Sep 2012 15:45:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGb4U-0006oi-QA for qemu-devel@nongnu.org; Tue, 25 Sep 2012 15:45:30 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8PJjUeP003902 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 25 Sep 2012 15:45:30 -0400 Message-ID: <506209D8.7070301@redhat.com> Date: Tue, 25 Sep 2012 15:45:28 -0400 From: Jeff Cody MIME-Version: 1.0 References: <26a2d4bf59b66b5b898ad5cbc2ac939cbd5ec255.1348589526.git.jcody@redhat.com> <5062024C.9050603@redhat.com> In-Reply-To: <5062024C.9050603@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/7] block: helper function, to find the base image of a chain Reply-To: jcody@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org On 09/25/2012 03:13 PM, Eric Blake wrote: > On 09/25/2012 10:29 AM, Jeff Cody wrote: >> This is a simple helper function, that will return the base image >> of a given image chain. >> >> Signed-off-by: Jeff Cody >> --- >> block.c | 16 ++++++++++++++++ >> block.h | 1 + >> 2 files changed, 17 insertions(+) > > Bikeshed question: Any reason patch 1/7 adds two helper functions, and > patch 4/7 adds a third? Perhaps it would be worth squashing all three > into one commit, or else having three commits, one per helper? But > there's no point in repainting things now, so: > > Reviewed-by: Eric Blake > The reasoning was the helper functions in 1/7 were to support block commit (patch 2/7), and the helper function in 4/7 was to support the block commit QMP command (patch 5/7), so it seemed logical to split them.