From: Jan Kiszka <jan.kiszka@web.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] add pci-serial device.
Date: Wed, 26 Sep 2012 02:18:12 +0200 [thread overview]
Message-ID: <506249C4.3030900@web.de> (raw)
In-Reply-To: <873925sm6e.fsf@codemonkey.ws>
[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]
On 2012-09-26 01:43, Anthony Liguori wrote:
> Gerd Hoffmann <kraxel@redhat.com> writes:
>
>> Hi,
>>
>> Two patches, first split up serial.c a bit,
>> then actually add the pci-based serial device.
>
> The series looks good to me. A couple requests:
>
> 1) Could you add a spec describing this new PCI device? Doesn't need to
> be more than a couple paragraphs since the device is super simple.
>
> 2) Could you make the inf file an separate patch and either include
> documentation in the commit message on how to use it with Windows or
> just add a comment to the inf file?
>
> This is a new PCI space for QEMU too. Is this a driver that is "owned"
> by QEMU and Red Hat is donating the PCI id or is this a driver that RH
> controls that we're implementing?
>
> The only reason I ask is whether this is something we can add new
> features to. I can't think of one off hand, but it can't hurt to work
> this out up front.
Multiport e.g. (to save PCI slots). There was some proposal recently to
add a model of an real multiport PCI card, just don't find the mail
right now...
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2012-09-26 0:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 11:28 [Qemu-devel] [PATCH 0/2] add pci-serial device Gerd Hoffmann
2012-09-24 11:28 ` [Qemu-devel] [PATCH 1/2] serial: split serial.c Gerd Hoffmann
2012-09-24 11:28 ` [Qemu-devel] [PATCH 2/2] serial: add pci variant Gerd Hoffmann
2012-09-25 23:43 ` [Qemu-devel] [PATCH 0/2] add pci-serial device Anthony Liguori
2012-09-26 0:18 ` Jan Kiszka [this message]
2012-09-26 6:54 ` Gerd Hoffmann
2012-09-26 6:44 ` Gerd Hoffmann
2012-09-26 13:01 ` Anthony Liguori
2012-09-27 5:53 ` Gerd Hoffmann
2012-09-28 10:06 ` Michael S. Tsirkin
2012-09-28 11:45 ` Gerd Hoffmann
2012-09-28 10:07 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506249C4.3030900@web.de \
--to=jan.kiszka@web.de \
--cc=anthony@codemonkey.ws \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).