From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGlM0-0006ca-3V for qemu-devel@nongnu.org; Wed, 26 Sep 2012 02:44:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGlLz-0006Cz-16 for qemu-devel@nongnu.org; Wed, 26 Sep 2012 02:44:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGlLy-0006Cn-PM for qemu-devel@nongnu.org; Wed, 26 Sep 2012 02:44:14 -0400 Message-ID: <5062A43A.1090506@redhat.com> Date: Wed, 26 Sep 2012 08:44:10 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1348486090-21177-1-git-send-email-kraxel@redhat.com> <873925sm6e.fsf@codemonkey.ws> In-Reply-To: <873925sm6e.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] add pci-serial device. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 09/26/12 01:43, Anthony Liguori wrote: > Gerd Hoffmann writes: > >> Hi, >> >> Two patches, first split up serial.c a bit, >> then actually add the pci-based serial device. > > The series looks good to me. A couple requests: > > 1) Could you add a spec describing this new PCI device? Doesn't need to > be more than a couple paragraphs since the device is super simple. Well, it is pretty strait forward: A single IO bar, 8 bytes in size, where the 16550 uart is mapped to: [kraxel@fedora ~]$ lspci -vse 00:0e.0 Serial controller: Red Hat, Inc. Device 0002 (rev 01) (prog-if 00 [8250]) Subsystem: Red Hat, Inc Device 1100 Physical Slot: 14 Flags: fast devsel, IRQ 11 I/O ports at c130 [size=8] Kernel driver in use: serial But I can surely add a comment about it. > 2) Could you make the inf file an separate patch and either include > documentation in the commit message on how to use it with Windows or > just add a comment to the inf file? I think a comment is better, easier to find than a commit message. Will do. > This is a new PCI space for QEMU too. It isn't new, I just followed what the pci bridge is doing (which has 1b36:0001). > Is this a driver that is "owned" > by QEMU and Red Hat is donating the PCI id or is this a driver that RH > controls that we're implementing? I consider it being owned by qemu. cheers, Gerd