From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGlQC-0007kU-3n for qemu-devel@nongnu.org; Wed, 26 Sep 2012 02:48:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGlQ8-0007tb-8z for qemu-devel@nongnu.org; Wed, 26 Sep 2012 02:48:36 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:53264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGlQ8-0007tT-25 for qemu-devel@nongnu.org; Wed, 26 Sep 2012 02:48:32 -0400 Received: by wiwc10 with SMTP id c10so2884162wiw.10 for ; Tue, 25 Sep 2012 23:48:31 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5062A53D.6050705@redhat.com> Date: Wed, 26 Sep 2012 08:48:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1348577763-12920-1-git-send-email-pbonzini@redhat.com> <1348577763-12920-10-git-send-email-pbonzini@redhat.com> <87r4ppn4nk.fsf@codemonkey.ws> In-Reply-To: <87r4ppn4nk.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/17] aio: prepare for introducing GSource-based dispatch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Il 26/09/2012 00:01, Anthony Liguori ha scritto: > > + revents = node->pfd.revents & node->pfd.events; > > + node->pfd.revents &= ~revents; > > This is interesting and I must admit I don't understand why it's > necessary. What case are you trying to handle? That's for the case where you got a write event for fd Y, but disabled the write handler from the handler of fd X (called before fd Y). But what the current code does is just eat the event, so I can do the same and set node->pfd.revents to 0. Paolo