From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Anand Avati <aavati@redhat.com>,
Vijay Bellur <vbellur@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Harsh Bora <harsh@linux.vnet.ibm.com>,
Amar Tumballi <amarts@redhat.com>,
qemu-devel@nongnu.org, "Richard W.M. Jones" <rjones@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>,
bharata@linux.vnet.ibm.com, Daniel Veillard <veillard@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v9 4/4] block: Support GlusterFS as a QEMU block backend.
Date: Wed, 26 Sep 2012 12:08:59 +0200 [thread overview]
Message-ID: <5062D43B.3000608@redhat.com> (raw)
In-Reply-To: <5062D24F.7030304@redhat.com>
Il 26/09/2012 12:00, Kevin Wolf ha scritto:
>> > +
>> > + ret = write(fd, (void *)&acb, sizeof(acb));
>> > + if (ret >= 0) {
>> > + break;
>> > + }
>> > + if (errno == EINTR) {
>> > + continue;
>> > + }
>> > + if (errno != EAGAIN) {
>> > + break;
>> > + }
> Variatio delectat? ;-)
>
> How about just do { ... } while (errno == EINTR || errno == EAGAIN); ?
That should be
while ((ret < 0) && (errno == EINTR || errno == EAGAIN));
However, fd here is blocking, so you can just use qemu_write_full.
Paolo
next prev parent reply other threads:[~2012-09-26 10:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 9:10 [Qemu-devel] [PATCH v9 0/4] GlusterFS support in QEMU - v9 Bharata B Rao
2012-09-24 9:10 ` [Qemu-devel] [PATCH v9 1/4] aio: Fix qemu_aio_wait() to maintain correct walking_handlers count Bharata B Rao
2012-09-24 9:12 ` [Qemu-devel] [PATCH v9 2/4] qemu: URI parsing library Bharata B Rao
2012-09-24 10:27 ` Richard W.M. Jones
2012-09-24 11:11 ` Paolo Bonzini
2012-09-27 9:03 ` Avi Kivity
2012-09-27 9:07 ` Paolo Bonzini
2012-10-02 4:59 ` Daniel Veillard
2012-10-02 6:16 ` Paolo Bonzini
2012-09-24 9:12 ` [Qemu-devel] [PATCH v9 3/4] configure: Add a config option for GlusterFS as block backend Bharata B Rao
2012-09-24 9:13 ` [Qemu-devel] [PATCH v9 4/4] block: Support GlusterFS as a QEMU " Bharata B Rao
2012-09-24 9:26 ` Paolo Bonzini
2012-09-24 9:44 ` Bharata B Rao
2012-09-26 10:00 ` Kevin Wolf
2012-09-26 10:08 ` Paolo Bonzini [this message]
2012-09-26 16:11 ` Bharata B Rao
2012-09-26 16:38 ` Paolo Bonzini
2012-09-27 6:41 ` Bharata B Rao
2012-09-27 7:19 ` Paolo Bonzini
2012-09-27 8:28 ` Bharata B Rao
2012-09-27 8:31 ` Paolo Bonzini
2012-10-03 15:50 ` [Qemu-devel] O_DIRECT on glusterfs (was Re: [PATCH v9 4/4] block: Support GlusterFS as a QEMU block backend) Paolo Bonzini
2012-10-03 17:58 ` Anand Avati
2012-10-03 18:17 ` Paolo Bonzini
2012-10-03 18:17 ` Anand Avati
2012-10-03 18:27 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5062D43B.3000608@redhat.com \
--to=pbonzini@redhat.com \
--cc=aavati@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=amarts@redhat.com \
--cc=avi@redhat.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=harsh@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@gmail.com \
--cc=vbellur@redhat.com \
--cc=veillard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).