From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49624)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1TGuth-0007AP-5L
	for qemu-devel@nongnu.org; Wed, 26 Sep 2012 12:55:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1TGutf-00052p-4A
	for qemu-devel@nongnu.org; Wed, 26 Sep 2012 12:55:40 -0400
Message-ID: <50633386.9020903@redhat.com>
Date: Wed, 26 Sep 2012 12:55:34 -0400
From: Cole Robinson <crobinso@redhat.com>
MIME-Version: 1.0
References: <505C4DA3.8020009@redhat.com>
	<1348231233-29841-1-git-send-email-otubo@linux.vnet.ibm.com>
In-Reply-To: <1348231233-29841-1-git-send-email-otubo@linux.vnet.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] New syscalls to the seccomp whitelist
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Otubo <otubo@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org

On 09/21/2012 08:40 AM, Eduardo Otubo wrote:
> Seccomp syscall whitelist updated after tests running qemu under
> libvirt. Reference to the bug -
> https://bugzilla.redhat.com/show_bug.cgi?id=855162
> 
> Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
> ---
>  qemu-seccomp.c | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index 64329a3..4712338 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -70,6 +70,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
>      { SCMP_SYS(setsockopt), 245},
>      { SCMP_SYS(uname), 245},
>      { SCMP_SYS(semget), 245},
> +    { SCMP_SYS(accept4), 241 },
>  #endif
>      { SCMP_SYS(eventfd2), 245 },
>      { SCMP_SYS(dup), 245 },
> @@ -107,7 +108,25 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
>      { SCMP_SYS(getsockname), 242 },
>      { SCMP_SYS(getpeername), 242 },
>      { SCMP_SYS(fdatasync), 242 },
> -    { SCMP_SYS(close), 242 }
> +    { SCMP_SYS(close), 242 },
> +    { SCMP_SYS(unlink), 241 },
> +    { SCMP_SYS(statfs), 241 },
> +    { SCMP_SYS(getuid), 241 },
> +    { SCMP_SYS(ftruncate), 241 },
> +    { SCMP_SYS(getegid), 241 },
> +    { SCMP_SYS(geteuid), 241 },
> +    { SCMP_SYS(getgid), 241 },
> +    { SCMP_SYS(getrlimit), 241 },
> +    { SCMP_SYS(set_tid_address), 241 },
> +    { SCMP_SYS(socketpair), 241 },
> +    { SCMP_SYS(fstatfs), 241 },
> +    { SCMP_SYS(epoll_create), 241 },
> +    { SCMP_SYS(epoll_ctl), 241 },
> +    { SCMP_SYS(epoll_wait), 241 },
> +    { SCMP_SYS(pipe), 241 },
> +    { SCMP_SYS(poll), 241 },
> +    { SCMP_SYS(rt_sigpending), 241 },
> +    { SCMP_SYS(rt_sigtimedwait), 241 },
>  };
>  
>  int seccomp_start(void)
> 

If this is required for libvirt + seccomp, might be a candidate for 1.2
stable, cc'ing. At the very least we will be carrying this in Fedora 18.

- Cole