From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGvoV-00044x-EE for qemu-devel@nongnu.org; Wed, 26 Sep 2012 13:54:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGvoR-0004yE-CK for qemu-devel@nongnu.org; Wed, 26 Sep 2012 13:54:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGvoR-0004y5-0f for qemu-devel@nongnu.org; Wed, 26 Sep 2012 13:54:19 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8QHsIU1004965 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 26 Sep 2012 13:54:18 -0400 Message-ID: <50634147.3090808@redhat.com> Date: Wed, 26 Sep 2012 11:54:15 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348675011-8794-1-git-send-email-pbonzini@redhat.com> <1348675011-8794-12-git-send-email-pbonzini@redhat.com> In-Reply-To: <1348675011-8794-12-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig92F8DF15747FCA44D37CCE8F" Subject: Re: [Qemu-devel] [PATCH v2 11/45] iostatus: move BlockdevOnError declaration to QAPI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig92F8DF15747FCA44D37CCE8F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/26/2012 09:56 AM, Paolo Bonzini wrote: > This will let block-stream reuse the enum. Places that used the enums > are renamed accordingly. >=20 > Signed-off-by: Paolo Bonzini > --- > +# > +# @stop: for guest operations, stop the virtual machine; > +# for jobs, pause the job > +# > +# @enospc: same as @stop on ENOSPC, same as @report otherwise. > +# > +# Since: 1.3 > +## > +{ 'enum': 'BlockdevOnError', > + 'data': ['report', 'ignore', 'enospc', 'stop'] } Bike-shedding - should the order of the docs match the order of the 'data' array (that is, should 'enospc' be last in both places)? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig92F8DF15747FCA44D37CCE8F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQY0FJAAoJEKeha0olJ0NqUAYH/Av0VhRhq9yeIluszAAz+D9r OKu0C1PF8bVTlTh/2kyyjt6FmWZFss0i53lFGZrGtDrzC/u3lGMIQ65b+fPkukT0 TgBYdzQDV2o29mvk7V9K1umGFDtBaFIacdeWop1Pq95ZtTPTt6zInfTrIEVTJqn+ ffhUeCc9IgPW/EcBT1YTQqA7oXJdTZ3SosI4BtHXU0uWmz7ATFnTkSz7+L2DWnxP O3KavkiYUG7qEZ8C3UxMjmaXT7gEB3H0+vrETcirgyxvDl0QEk/lFhw6U5nuCX9W IxyiSwg1aowspGb8RY2E6JmNGeiu0Ktl0lAe+n0aTzQ6ox8qo2GYqjs4OATmqoY= =YyLY -----END PGP SIGNATURE----- --------------enig92F8DF15747FCA44D37CCE8F--