From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGx0C-00025E-9K for qemu-devel@nongnu.org; Wed, 26 Sep 2012 15:10:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGx0B-0004ZL-5A for qemu-devel@nongnu.org; Wed, 26 Sep 2012 15:10:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGx0A-0004Xi-S5 for qemu-devel@nongnu.org; Wed, 26 Sep 2012 15:10:31 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8QJATJa029943 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 26 Sep 2012 15:10:30 -0400 Message-ID: <50635322.70305@redhat.com> Date: Wed, 26 Sep 2012 13:10:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348675011-8794-1-git-send-email-pbonzini@redhat.com> <1348675011-8794-15-git-send-email-pbonzini@redhat.com> In-Reply-To: <1348675011-8794-15-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig51F66C2C8033873198895173" Subject: Re: [Qemu-devel] [PATCH v2 14/45] block: introduce block job error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig51F66C2C8033873198895173 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/26/2012 09:56 AM, Paolo Bonzini wrote: > The following behaviors are possible: >=20 > 'report': The behavior is the same as in 1.1. An I/O error, > respectively during a read or a write, will complete the job immediatel= y > with an error code. >=20 > 'ignore': An I/O error, respectively during a read or a write, will be > ignored. For streaming, the job will complete with an error and the > backing file will be left in place. For mirroring, the sector will be > marked again as dirty and re-examined later. >=20 > 'stop': The job will be paused and the job iostatus will be set to > failed or nospace, while the VM will keep running. This can only be > specified if the block device has rerror=3Dstop and werror=3Dstop or en= ospc. >=20 > 'enospc': Behaves as 'stop' for ENOSPC errors, 'report' for others. >=20 > +Emitted when a block job encounters an error. > + > +Data: > + > +- "device": device name (json-string) > +- "operation": I/O operation (json-string, "read" or "write") For symmetry with BLOCK_JOB_{CANCELLED,COMPLETED}, you also need: - "type": Job type ("stream" for image streaming, json-string) Libvirt would like to key off of the 'type' field for all three events. Besides, if management issues several block commands in a row, and only then starts processing the pending event queue, it would be nice to know whether the error stemmed from a 'stream', 'mirror', or (when combined with Jeff's patches) 'commit' job. > +++ b/qapi-schema.json > @@ -1127,11 +1127,14 @@ > # > # @speed: the rate limit, bytes per second > # > +# @io-status: the status of the job (since 1.2) 1.3 --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig51F66C2C8033873198895173 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQY1MjAAoJEKeha0olJ0NqQbQH+QE/729abHcmwge67ZytEq3t IFciX0FkuRevZEgrFgUKOhKYBY91Da1/4+1vJE41NO2VZV20IifLnRsoUvT5ENbX aQPWQfJEiJKj/xxWFrMQZ+0vxiJp488jItUuUdJdK+a2CFotgdxPG8d+xV+duiQb Dl2oNvigA3P3ero9gOFAo369I9IpHlgKqj+bH2YATU4gbJXXxwf09oAzK0JDE4O8 C2K/im+HWcW9Lsnwy1BmGnNCD+mp/bCYs3bvnxnWB9Zqb9xtmsBiuxWOu+Qiql71 As27RmK9aleah5PPYihvTqAvaGb4W4qwg2QBytBe/1ZfS+EmpOsYz7n6qKecFjc= =xAJl -----END PGP SIGNATURE----- --------------enig51F66C2C8033873198895173--