From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGxGI-0000k6-R9 for qemu-devel@nongnu.org; Wed, 26 Sep 2012 15:27:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGxGE-00032d-Fw for qemu-devel@nongnu.org; Wed, 26 Sep 2012 15:27:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGxGE-00032N-6G for qemu-devel@nongnu.org; Wed, 26 Sep 2012 15:27:06 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8QJR5Fs032142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 26 Sep 2012 15:27:05 -0400 Message-ID: <50635707.4080909@redhat.com> Date: Wed, 26 Sep 2012 13:27:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348675011-8794-1-git-send-email-pbonzini@redhat.com> <1348675011-8794-15-git-send-email-pbonzini@redhat.com> <50635322.70305@redhat.com> In-Reply-To: <50635322.70305@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigA3C49BCA47350047E6E9FC92" Subject: Re: [Qemu-devel] [PATCH v2 14/45] block: introduce block job error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, Paolo Bonzini , jcody@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA3C49BCA47350047E6E9FC92 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/26/2012 01:10 PM, Eric Blake wrote: >> +Emitted when a block job encounters an error. >> + >> +Data: >> + >> +- "device": device name (json-string) >> +- "operation": I/O operation (json-string, "read" or "write") >=20 > For symmetry with BLOCK_JOB_{CANCELLED,COMPLETED}, you also need: > - "type": Job type ("stream" for image streaming, json-string) >=20 > Libvirt would like to key off of the 'type' field for all three events.= > Besides, if management issues several block commands in a row, and onl= y > then starts processing the pending event queue, it would be nice to kno= w > whether the error stemmed from a 'stream', 'mirror', or (when combined > with Jeff's patches) 'commit' job. For that matter, maybe qapi-schema.json should define an enum: { 'enum': 'BlockJobType', 'data': [ 'stream', 'mirror', 'commit' ] } and have the job type listed throughout the various QMP calls as a member of that enum, rather than open-coded strings, to make it easier the next time we add a job type. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigA3C49BCA47350047E6E9FC92 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQY1cIAAoJEKeha0olJ0NqqZQH/ROGgPJ6w2ExDRMAYj0B4QWK xEOomA46VINuoww9X3O0lr6MFFr5tfMGMm77jhybdNjrR44EK6rcFdbPicZWpnCu PvVff2YK88IrWRJ2z4A8GOIPFSF57EBjezSnkFGOD9UsLciuaRru+N7jYk+nHQUU neg1I6d3IlS1Kg/yE5sYR7FRkxA7PnuCTgDX64NrpatU37chlQ97AGMJGjB7APwQ Jw3CMOiPbP2irlequRKn72ClRxcceUGxnqpPec1clvW5cbXqODUz+tEVkMRBxds8 dN45tGZ4u4N4krzl3MtPPMnyO3P4DeaevlI2ap+84sAQlp5EZP+gaP37UWEn/dE= =2MUK -----END PGP SIGNATURE----- --------------enigA3C49BCA47350047E6E9FC92--