From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGz55-0001A1-1h for qemu-devel@nongnu.org; Wed, 26 Sep 2012 17:23:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGz53-0000Ub-Nu for qemu-devel@nongnu.org; Wed, 26 Sep 2012 17:23:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGz53-0000US-FH for qemu-devel@nongnu.org; Wed, 26 Sep 2012 17:23:41 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8QLNeg1015198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 26 Sep 2012 17:23:40 -0400 Message-ID: <50637258.4080200@redhat.com> Date: Wed, 26 Sep 2012 15:23:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348691138-12879-1-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1348691138-12879-1-git-send-email-lcapitulino@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigFA1159924B40A94714C606BC" Subject: Re: [Qemu-devel] [PATCH v3 0/3] qmp: send-key: accept key codes in hex List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: armbru@redhat.com, akong@redhat.com, qemu-devel@nongnu.org, avi@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFA1159924B40A94714C606BC Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/26/2012 02:25 PM, Luiz Capitulino wrote: > o v3 >=20 > - doc & log fixups > - rename KeyCode.hex to KeyCode.number >=20 > This actually fixes a regression introduced by the qapi conversion, > please refer to patch 2/3 for details. >=20 > It's also important to note that this series changes the QMP > interface for the send-key command, but this shouldn't be a problem > as we're still in development phase. >=20 > Luiz Capitulino (3): > input: qmp_send_key(): simplify > qmp: qmp_send_key(): accept key codes in hex > input: index_from_key(): drop unused code >=20 > hmp.c | 43 +++++++++++++++++++++----------- > input.c | 75 ++++++++++++++++++++++++++++--------------------= -------- > qapi-schema.json | 20 ++++++++++++--- > 3 files changed, 84 insertions(+), 54 deletions(-) >=20 Series: Reviewed-by: Eric Blake --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigFA1159924B40A94714C606BC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQY3JZAAoJEKeha0olJ0Nqa5UH/AoOPvauptEeSg3JoppaKuBP BeebzBHSER8TiVluXXMXoiwB7uQkHSj6hiwWY8ke8pdcDv2xu9SsCgvGEaWa3hqm W5P5ijT47FmLMRRFeQO6ylk8NgTl+W0RBGyfMgXIJYTxE2PomR139ReuuMss5Q0e i07z2z+t2qcw+BdKJiqBhE2/XrV0WWuk0hvY1aBq9P7e7RA2FfurtAOXoVTyyROA du+S1QMUyToV3epgBda/SkVYRsWP7BOh+h3f1g1WFxTVirTsEvUP8mWT0KVrE11v u07jNqDGcu9BsNyg4K3AGzcHeIgZvUSppIqe02k96yTm5DAD27R8wSn1SGa7u24= =A5Tr -----END PGP SIGNATURE----- --------------enigFA1159924B40A94714C606BC--