* Re: [Qemu-devel] [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support [not found] ` <CAFWqQMRCnf_7NLWWiuCjGXpwS+vBzp0gjKj_rAmC0Y_dEcUstQ@mail.gmail.com> @ 2012-09-26 8:09 ` Michal Privoznik 2012-09-26 20:46 ` Anthony Liguori 0 siblings, 1 reply; 3+ messages in thread From: Michal Privoznik @ 2012-09-26 8:09 UTC (permalink / raw) To: Doug Goldstein; +Cc: libvir-list, Yan Vugenfirer, QEMU Developers On 25.09.2012 19:08, Doug Goldstein wrote: > On Tue, Sep 25, 2012 at 12:01 PM, Daniel P. Berrange > <berrange@redhat.com> wrote: >> On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wrote: >>> On 09/25/2012 06:54 AM, Daniel P. Berrange wrote: >>>> On Tue, Sep 25, 2012 at 02:49:00PM +0200, Michal Privoznik wrote: >>>>> On 25.09.2012 10:58, Dmitry Fleytman wrote: >>>>>> This patch fixes incorrect help screen parsing for QEMU 1.0.1 package >>>>>> Version line changed from >>>>>> QEMU emulator version 1.0 (qemu-kvm-1.0), Copyright (c) 2003-2008 Fabrice Bellard >>>>>> To >>>>>> QEMU emulator version 1.0,1 (qemu-kvm-1.0.1), Copyright (c) 2003-2008 Fabrice Bellard >>>>> >>>>> This seems like a bug to me. If it is a micro version number, why is it >>>>> delimited with comma instead of dot? If it is not a micro version >>>>> number, can we threat it like it is? >>>> >>>> I agree, it smells very much like a QEMU/distro bug to me. >>> >>> It is an upstream bug: >>> >>> https://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02527.html >>> >>> Distros should probably be backporting that particular patch, but >>> there's still the question of whether we should deal with it in libvirt >>> because it is upstream. >> >> Well it is a bug on only one branch of upstream, that was promptly >> fixed, so I still don't think we should complicate libvirt by dealing >> with it. It is trivial for QEMU maintainers to fix >> >> >> Daniel >> -- > > FWIW, the raw tarball from qemu.org still contains the bug. They > didn't reissue the tarball. First commit on the list here: > http://wiki.qemu.org/ChangeLog/1.0 > [CC'ing QEMU devel list] Maybe QEMU guys can reissue the tarball since Fedora (and probably other distros as well) is using this tarball when building a package? Or is it distro's business to backport the patch? Michal ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support 2012-09-26 8:09 ` [Qemu-devel] [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support Michal Privoznik @ 2012-09-26 20:46 ` Anthony Liguori 2012-09-27 6:45 ` Michal Privoznik 0 siblings, 1 reply; 3+ messages in thread From: Anthony Liguori @ 2012-09-26 20:46 UTC (permalink / raw) To: Michal Privoznik, Doug Goldstein Cc: libvir-list, Yan Vugenfirer, QEMU Developers Michal Privoznik <mprivozn@redhat.com> writes: > On 25.09.2012 19:08, Doug Goldstein wrote: >> On Tue, Sep 25, 2012 at 12:01 PM, Daniel P. Berrange >> <berrange@redhat.com> wrote: >>> On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wrote: >>>> On 09/25/2012 06:54 AM, Daniel P. Berrange wrote: >>>>> On Tue, Sep 25, 2012 at 02:49:00PM +0200, Michal Privoznik wrote: >>>>>> On 25.09.2012 10:58, Dmitry Fleytman wrote: >>>>>>> This patch fixes incorrect help screen parsing for QEMU 1.0.1 package >>>>>>> Version line changed from >>>>>>> QEMU emulator version 1.0 (qemu-kvm-1.0), Copyright (c) 2003-2008 Fabrice Bellard >>>>>>> To >>>>>>> QEMU emulator version 1.0,1 (qemu-kvm-1.0.1), Copyright (c) 2003-2008 Fabrice Bellard >>>>>> >>>>>> This seems like a bug to me. If it is a micro version number, why is it >>>>>> delimited with comma instead of dot? If it is not a micro version >>>>>> number, can we threat it like it is? >>>>> >>>>> I agree, it smells very much like a QEMU/distro bug to me. >>>> >>>> It is an upstream bug: >>>> >>>> https://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02527.html >>>> >>>> Distros should probably be backporting that particular patch, but >>>> there's still the question of whether we should deal with it in libvirt >>>> because it is upstream. >>> >>> Well it is a bug on only one branch of upstream, that was promptly >>> fixed, so I still don't think we should complicate libvirt by dealing >>> with it. It is trivial for QEMU maintainers to fix >>> >>> >>> Daniel >>> -- >> >> FWIW, the raw tarball from qemu.org still contains the bug. They >> didn't reissue the tarball. First commit on the list here: >> http://wiki.qemu.org/ChangeLog/1.0 >> > > [CC'ing QEMU devel list] > > Maybe QEMU guys can reissue the tarball since Fedora (and probably other > distros as well) is using this tarball when building a package? > Or is it distro's business to backport the patch? We released a qemu-1.0.1-1.tar.bz2 that contained the fixed VERSION file. Regards, Anthony Liguori > > Michal ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support 2012-09-26 20:46 ` Anthony Liguori @ 2012-09-27 6:45 ` Michal Privoznik 0 siblings, 0 replies; 3+ messages in thread From: Michal Privoznik @ 2012-09-27 6:45 UTC (permalink / raw) To: Anthony Liguori Cc: libvir-list, Yan Vugenfirer, Doug Goldstein, QEMU Developers On 26.09.2012 22:46, Anthony Liguori wrote: > Michal Privoznik <mprivozn@redhat.com> writes: > >> On 25.09.2012 19:08, Doug Goldstein wrote: >>> On Tue, Sep 25, 2012 at 12:01 PM, Daniel P. Berrange >>> <berrange@redhat.com> wrote: >>>> On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wrote: >>>>> On 09/25/2012 06:54 AM, Daniel P. Berrange wrote: >>>>>> On Tue, Sep 25, 2012 at 02:49:00PM +0200, Michal Privoznik wrote: >>>>>>> On 25.09.2012 10:58, Dmitry Fleytman wrote: >>>>>>>> This patch fixes incorrect help screen parsing for QEMU 1.0.1 package >>>>>>>> Version line changed from >>>>>>>> QEMU emulator version 1.0 (qemu-kvm-1.0), Copyright (c) 2003-2008 Fabrice Bellard >>>>>>>> To >>>>>>>> QEMU emulator version 1.0,1 (qemu-kvm-1.0.1), Copyright (c) 2003-2008 Fabrice Bellard >>>>>>> >>>>>>> This seems like a bug to me. If it is a micro version number, why is it >>>>>>> delimited with comma instead of dot? If it is not a micro version >>>>>>> number, can we threat it like it is? >>>>>> >>>>>> I agree, it smells very much like a QEMU/distro bug to me. >>>>> >>>>> It is an upstream bug: >>>>> >>>>> https://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02527.html >>>>> >>>>> Distros should probably be backporting that particular patch, but >>>>> there's still the question of whether we should deal with it in libvirt >>>>> because it is upstream. >>>> >>>> Well it is a bug on only one branch of upstream, that was promptly >>>> fixed, so I still don't think we should complicate libvirt by dealing >>>> with it. It is trivial for QEMU maintainers to fix >>>> >>>> >>>> Daniel >>>> -- >>> >>> FWIW, the raw tarball from qemu.org still contains the bug. They >>> didn't reissue the tarball. First commit on the list here: >>> http://wiki.qemu.org/ChangeLog/1.0 >>> >> >> [CC'ing QEMU devel list] >> >> Maybe QEMU guys can reissue the tarball since Fedora (and probably other >> distros as well) is using this tarball when building a package? >> Or is it distro's business to backport the patch? > > We released a qemu-1.0.1-1.tar.bz2 that contained the fixed VERSION > file. > > Regards, > > Anthony Liguori Ah, I didn't know that. Maybe it's worth updating [1] then, isn't it? Regards Michal 1: http://wiki.qemu.org/Download ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-27 6:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1348563490-15598-1-git-send-email-dmitry@daynix.com>
[not found] ` <5061A83C.2070801@redhat.com>
[not found] ` <20120925125429.GI5408@redhat.com>
[not found] ` <5061E273.8010009@redhat.com>
[not found] ` <20120925170109.GC24588@redhat.com>
[not found] ` <CAFWqQMRCnf_7NLWWiuCjGXpwS+vBzp0gjKj_rAmC0Y_dEcUstQ@mail.gmail.com>
2012-09-26 8:09 ` [Qemu-devel] [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support Michal Privoznik
2012-09-26 20:46 ` Anthony Liguori
2012-09-27 6:45 ` Michal Privoznik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).