From: Paolo Bonzini <pbonzini@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com,
qemu-devel@nongnu.org, blauwirbel@gmail.com, eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH V3 1/5] libqblock build system
Date: Thu, 27 Sep 2012 09:14:17 +0200 [thread overview]
Message-ID: <5063FCC9.1090509@redhat.com> (raw)
In-Reply-To: <5063B6BD.3010309@linux.vnet.ibm.com>
Il 27/09/2012 04:15, Wenchao Xia ha scritto:
> 于 2012-9-19 17:57, Paolo Bonzini 写道:
>> Il 19/09/2012 08:35, Wenchao Xia ha scritto:
>>>>>
>>>>> +QEMU_OBJS=$(tools-obj-y) $(block-obj-y)
>>>>> +QEMU_OBJS_FILTERED=$(filter %.o,$(QEMU_OBJS))
>>>>
>>>> What does this filter out?
>>>>
>>> $(block-obj-y) contains /block, which would cause trouble in
>>> building,
>>> so filtered it out.
>>
>> I think that's because you have to call unnest-vars, not unnest-vars-1.
>>
>> Paolo
>>
> Tried with unnest-vars, it will create some unnessary directories in
> ./libqblock, unnest-vars-1 seems more reasonable.
Don't worry about unnecessary directories, worry about correctness.
Paolo
next prev parent reply other threads:[~2012-09-27 7:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 9:01 [Qemu-devel] [PATCH V3 0/5] libqblock qemu block layer library Wenchao Xia
2012-09-18 9:01 ` [Qemu-devel] [PATCH V3 1/5] libqblock build system Wenchao Xia
2012-09-18 10:05 ` Paolo Bonzini
2012-09-19 6:35 ` Wenchao Xia
2012-09-19 9:57 ` Paolo Bonzini
2012-09-27 2:15 ` Wenchao Xia
2012-09-27 7:14 ` Paolo Bonzini [this message]
2012-09-18 10:31 ` Paolo Bonzini
2012-09-18 9:01 ` [Qemu-devel] [PATCH V3 2/5] libqblock type defines Wenchao Xia
2012-09-18 10:05 ` Paolo Bonzini
2012-09-19 3:23 ` Wenchao Xia
2012-09-18 9:01 ` [Qemu-devel] [PATCH V3 3/5] libqblock API Wenchao Xia
2012-09-18 9:01 ` [Qemu-devel] [PATCH V3 4/5] libqblock test build system Wenchao Xia
2012-09-18 10:10 ` Paolo Bonzini
2012-09-19 6:39 ` Wenchao Xia
2012-09-18 9:01 ` [Qemu-devel] [PATCH V3 5/5] libqblock test example code Wenchao Xia
2012-09-18 10:10 ` Paolo Bonzini
2012-09-19 6:40 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5063FCC9.1090509@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).