From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35165)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TH8In-0003X6-2n
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 03:14:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TH8Ii-0005bb-Rx
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 03:14:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6667)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TH8Ii-0005bO-K3
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 03:14:24 -0400
Message-ID: <5063FCC9.1090509@redhat.com>
Date: Thu, 27 Sep 2012 09:14:17 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1347958919-30380-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1347958919-30380-2-git-send-email-xiawenc@linux.vnet.ibm.com>
	<50584784.7040600@redhat.com> <505967AD.9060408@linux.vnet.ibm.com>
	<50599726.2010307@redhat.com> <5063B6BD.3010309@linux.vnet.ibm.com>
In-Reply-To: <5063B6BD.3010309@linux.vnet.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V3 1/5] libqblock build system
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, eblake@redhat.com

Il 27/09/2012 04:15, Wenchao Xia ha scritto:
> =E4=BA=8E 2012-9-19 17:57, Paolo Bonzini =E5=86=99=E9=81=93:
>> Il 19/09/2012 08:35, Wenchao Xia ha scritto:
>>>>>
>>>>> +QEMU_OBJS=3D$(tools-obj-y) $(block-obj-y)
>>>>> +QEMU_OBJS_FILTERED=3D$(filter %.o,$(QEMU_OBJS))
>>>>
>>>> What does this filter out?
>>>>
>>>    $(block-obj-y) contains /block, which would cause trouble in
>>> building,
>>> so filtered it out.
>>
>> I think that's because you have to call unnest-vars, not unnest-vars-1.
>>
>> Paolo
>>
>   Tried with unnest-vars, it will create some unnessary directories in
> ./libqblock, unnest-vars-1 seems more reasonable.

Don't worry about unnecessary directories, worry about correctness.

Paolo