From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THAK9-0006UM-De for qemu-devel@nongnu.org; Thu, 27 Sep 2012 05:24:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THAK4-0002QP-Fr for qemu-devel@nongnu.org; Thu, 27 Sep 2012 05:24:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20251) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THAK4-0002QE-7s for qemu-devel@nongnu.org; Thu, 27 Sep 2012 05:23:56 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8R9Ntnc001414 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Sep 2012 05:23:55 -0400 Message-ID: <50641B28.40008@redhat.com> Date: Thu, 27 Sep 2012 11:23:52 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1348675011-8794-1-git-send-email-pbonzini@redhat.com> <1348675011-8794-12-git-send-email-pbonzini@redhat.com> <50634147.3090808@redhat.com> In-Reply-To: <50634147.3090808@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 11/45] iostatus: move BlockdevOnError declaration to QAPI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org Il 26/09/2012 19:54, Eric Blake ha scritto: >> > +# >> > +# @stop: for guest operations, stop the virtual machine; >> > +# for jobs, pause the job >> > +# >> > +# @enospc: same as @stop on ENOSPC, same as @report otherwise. >> > +# >> > +# Since: 1.3 >> > +## >> > +{ 'enum': 'BlockdevOnError', >> > + 'data': ['report', 'ignore', 'enospc', 'stop'] } > Bike-shedding - should the order of the docs match the order of the > 'data' array (that is, should 'enospc' be last in both places)? Why not. Paolo