From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35914)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1THAKO-0006sC-C0
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 05:24:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1THAKK-0002ST-9B
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 05:24:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56045)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1THAKK-0002SO-0n
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 05:24:12 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8R9OBGK015979
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 27 Sep 2012 05:24:11 -0400
Message-ID: <50641B37.2020908@redhat.com>
Date: Thu, 27 Sep 2012 11:24:07 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1348675011-8794-1-git-send-email-pbonzini@redhat.com>
	<1348675011-8794-15-git-send-email-pbonzini@redhat.com>
	<50635322.70305@redhat.com>
In-Reply-To: <50635322.70305@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 14/45] block: introduce block job error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org

Il 26/09/2012 21:10, Eric Blake ha scritto:
>> > +- "device": device name (json-string)
>> > +- "operation": I/O operation (json-string, "read" or "write")
> For symmetry with BLOCK_JOB_{CANCELLED,COMPLETED}, you also need:
> - "type":     Job type ("stream" for image streaming, json-string)
> 
> Libvirt would like to key off of the 'type' field for all three events.
>  Besides, if management issues several block commands in a row, and only
> then starts processing the pending event queue, it would be nice to know
> whether the error stemmed from a 'stream', 'mirror', or (when combined
> with Jeff's patches) 'commit' job.
> 
> 

Let's add it as a follow-up.

Paolo