From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THALL-0008Fm-3l for qemu-devel@nongnu.org; Thu, 27 Sep 2012 05:25:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THALF-0002sh-96 for qemu-devel@nongnu.org; Thu, 27 Sep 2012 05:25:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THALE-0002rH-Pa for qemu-devel@nongnu.org; Thu, 27 Sep 2012 05:25:09 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8R9P8Te006617 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Sep 2012 05:25:08 -0400 Message-ID: <50641B71.7070807@redhat.com> Date: Thu, 27 Sep 2012 11:25:05 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1348675011-8794-1-git-send-email-pbonzini@redhat.com> <1348675011-8794-26-git-send-email-pbonzini@redhat.com> <50639746.6000205@redhat.com> In-Reply-To: <50639746.6000205@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 25/45] block: introduce BLOCK_JOB_READY event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org Il 27/09/2012 02:01, Eric Blake ha scritto: >> > +{ "event": "BLOCK_JOB_READY", >> > + "data": { "device": "ide0-hd1", >> > + "operation": "write", >> > + "action": "stop" }, > You didn't document operation and action; are you missing documentation > for this event, or are they bad copy-and-paste in the example? The latter. Paolo