From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THANh-0000gN-RV for qemu-devel@nongnu.org; Thu, 27 Sep 2012 05:27:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THANc-0003yq-3v for qemu-devel@nongnu.org; Thu, 27 Sep 2012 05:27:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THANb-0003yl-S7 for qemu-devel@nongnu.org; Thu, 27 Sep 2012 05:27:36 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8R9RZaU018344 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Sep 2012 05:27:35 -0400 Message-ID: <50641C04.9040609@redhat.com> Date: Thu, 27 Sep 2012 11:27:32 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1348675011-8794-1-git-send-email-pbonzini@redhat.com> <1348675011-8794-36-git-send-email-pbonzini@redhat.com> <5063BFAE.20707@redhat.com> In-Reply-To: <5063BFAE.20707@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 35/45] add hierarchical bitmap data type and test cases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org Il 27/09/2012 04:53, Eric Blake ha scritto: >> +++ b/hbitmap.c >> > @@ -0,0 +1,400 @@ >> > +/* >> > + * Hierarchical Bitmap Data Type >> > + * >> > + * Copyright Red Hat, Inc., 2012 > vs. > >> > +++ b/tests/test-hbitmap.c >> > @@ -0,0 +1,408 @@ >> > +/* >> > + * Hierarchical bitmap unit-tests. >> > + * >> > + * Copyright (C) 2012 Red Hat Inc. > Is there a preferred form for the copyright line? > I say it depends on where you cut-and-paste from. :) I think the one with the (C) is better. Paolo