From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THApn-0007L0-7x for qemu-devel@nongnu.org; Thu, 27 Sep 2012 05:56:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THApm-0006SX-9h for qemu-devel@nongnu.org; Thu, 27 Sep 2012 05:56:43 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:45972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THApl-0006SI-Kz for qemu-devel@nongnu.org; Thu, 27 Sep 2012 05:56:42 -0400 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Sep 2012 15:26:37 +0530 Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8R9uXNw36700324 for ; Thu, 27 Sep 2012 15:26:34 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8R9uWHD013733 for ; Thu, 27 Sep 2012 19:56:33 +1000 Message-ID: <506422CD.2040406@linux.vnet.ibm.com> Date: Thu, 27 Sep 2012 17:56:29 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1348712642-4427-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1348712642-4427-5-git-send-email-xiawenc@linux.vnet.ibm.com> <50640E8F.2000003@redhat.com> In-Reply-To: <50640E8F.2000003@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Paolo Bonzini 于 2012-9-27 16:30, Paolo Bonzini 写道: > Il 27/09/2012 04:24, Wenchao Xia ha scritto: >> +#libqblock >> +LIBQBLOCK_TEST_DIR=$(SRC_PATH)/tests/libqblock/test_images >> +qtest-lib-y=$(patsubst %.o, %.lo,$(qtest-obj-y)) > > I don't think you need qtest-obj-y for anything. > OK, I will remove it. >> +libqblock-la-path = $(libqblock-lib-path)/$(libqblock-lib-la) >> + >> +tests/libqblock/%.lo: QEMU_INCLUDES += -I$(libqblock-lib-path) -Itests >> + >> +check-libqblock-y = tests/libqblock/check-libqblock-qcow2$(EXESUF) >> +tests/libqblock/check-libqblock-qcow2$(EXESUF): tests/libqblock/libqblock-qcow2.lo $(libqblock-la-path) $(qtest-lib-y) > > No need to use .lo here. > OK. >> + $(call quiet-command,$(LIBTOOL) --mode=link --quiet --tag=CC $(CC) -shared -rpath $(libdir) -o $@ $^," lt LINK $@") >> + > >> +$(libqblock-la-path): >> + @echo "Building libqblock.la..." >> + $(call quiet-command,$(MAKE) -C $(SRC_PATH) $(libqblock-lib-la),) > > No need for this. OK. > >> +$(LIBQBLOCK_TEST_DIR): >> + @echo "Make libqblock test directory" >> + mkdir $(LIBQBLOCK_TEST_DIR) > > You can leave the files in tests/ directly, and avoid this as well. Having a new directory will make clean easier, otherwise the script will need to know each image file names created, whose filename are generated in test C code at runtime. > >> +check-libqblock: $(libqblock-la-path) $(LIBQBLOCK_TEST_DIR) $(patsubst %,check-%, $(check-libqblock-y)) > > Please add > > check: check-libqblock > > here, so that if libtool is present the check is run automatically. OK. > > Paolo > -- Best Regards Wenchao Xia