From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THB9q-0005Bn-K1 for qemu-devel@nongnu.org; Thu, 27 Sep 2012 06:17:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THB9l-0004qy-L4 for qemu-devel@nongnu.org; Thu, 27 Sep 2012 06:17:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THB9l-0004qm-Dh for qemu-devel@nongnu.org; Thu, 27 Sep 2012 06:17:21 -0400 Message-ID: <506427AD.70608@redhat.com> Date: Thu, 27 Sep 2012 12:17:17 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1348712642-4427-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1348712642-4427-5-git-send-email-xiawenc@linux.vnet.ibm.com> <50640E8F.2000003@redhat.com> <506422CD.2040406@linux.vnet.ibm.com> In-Reply-To: <506422CD.2040406@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: qemu-devel@nongnu.org Il 27/09/2012 11:56, Wenchao Xia ha scritto: >> >>> +$(LIBQBLOCK_TEST_DIR): >>> + @echo "Make libqblock test directory" >>> + mkdir $(LIBQBLOCK_TEST_DIR) >> >> You can leave the files in tests/ directly, and avoid this as well. > Having a new directory will make clean easier, otherwise the script > will need to know each image file names created, whose filename are > generated in test C code at runtime. If you want a subdirectory for images, you can create it in the test code. Paolo