From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THChe-0007st-PK for qemu-devel@nongnu.org; Thu, 27 Sep 2012 07:56:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THChd-0004eJ-0z for qemu-devel@nongnu.org; Thu, 27 Sep 2012 07:56:26 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:56858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THChc-0004eE-Qr for qemu-devel@nongnu.org; Thu, 27 Sep 2012 07:56:24 -0400 Received: by padfb10 with SMTP id fb10so1291554pad.4 for ; Thu, 27 Sep 2012 04:56:23 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <50643EE1.1000509@redhat.com> Date: Thu, 27 Sep 2012 13:56:17 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1348722865-20564-1-git-send-email-wdongxu@linux.vnet.ibm.com> <1348722865-20564-7-git-send-email-wdongxu@linux.vnet.ibm.com> In-Reply-To: <1348722865-20564-7-git-send-email-wdongxu@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 6/7] create new function: qemu_opt_set_number List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dong Xu Wang Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com Il 27/09/2012 07:14, Dong Xu Wang ha scritto: > +int qemu_opt_set_number(QemuOpts *opts, const char *name, int64_t val) > +{ > + char buffer[1024]; > + snprintf(buffer, sizeof(buffer), "%" PRId64, val); > + return qemu_opt_set(opts, name, buffer); > +} This has the same problem as qemu_opt_set_bool after patch 1. Paolo