From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THCok-0003Ga-Qe for qemu-devel@nongnu.org; Thu, 27 Sep 2012 08:03:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THCoj-0006ss-Pc for qemu-devel@nongnu.org; Thu, 27 Sep 2012 08:03:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THCoj-0006se-Gx for qemu-devel@nongnu.org; Thu, 27 Sep 2012 08:03:45 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8RC3ilX025582 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Sep 2012 08:03:45 -0400 Message-ID: <5064409D.2080306@redhat.com> Date: Thu, 27 Sep 2012 14:03:41 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1348675011-8794-1-git-send-email-pbonzini@redhat.com> <1348675011-8794-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1348675011-8794-4-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 03/45] block: fix documentation of block_job_cancel_sync List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: jcody@redhat.com, qemu-devel@nongnu.org Am 26.09.2012 17:56, schrieb Paolo Bonzini: > Do this in a separate commit before we move the functions to > blockjob.h. > > Signed-off-by: Paolo Bonzini > --- > v1->v2: split out of the next patch > > block_int.h | 4 ++-- > 1 file modificato, 2 inserzioni(+), 2 rimozioni(-) > > diff --git a/block_int.h b/block_int.h > index ac4245c..7bb95b7 100644 > --- a/block_int.h > +++ b/block_int.h > @@ -425,10 +425,10 @@ void block_job_cancel(BlockJob *job); > bool block_job_is_cancelled(BlockJob *job); > > /** > - * block_job_cancel: > + * block_job_cancel_sync: > * @job: The job to be canceled. > * > - * Asynchronously cancel the job and wait for it to reach a quiescent > + * Synchronously cancel the job and wait for it to reach a quiescent > * state. Note that the completion callback will still be called > * asynchronously, hence it is *not* valid to call #bdrv_delete > * immediately after #block_job_cancel_sync. Users of block jobs I still don't agree with the s/Async/Sync/, in my opinion it contradicts the rest of the comment. If it did cancel the job synchronously, then the job would be immediately completed, and there would be no need to wait for a quiescent state nor would the completion callback occur later. Kevin