From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THDEz-0002Wx-1B for qemu-devel@nongnu.org; Thu, 27 Sep 2012 08:30:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THDEv-0000Aj-39 for qemu-devel@nongnu.org; Thu, 27 Sep 2012 08:30:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THDEu-00009T-NT for qemu-devel@nongnu.org; Thu, 27 Sep 2012 08:30:48 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8RCUmSw002877 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Sep 2012 08:30:48 -0400 Message-ID: <506446F5.7060605@redhat.com> Date: Thu, 27 Sep 2012 14:30:45 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1348675011-8794-1-git-send-email-pbonzini@redhat.com> <1348675011-8794-10-git-send-email-pbonzini@redhat.com> In-Reply-To: <1348675011-8794-10-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 09/45] block: rename block_job_complete to block_job_completed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: jcody@redhat.com, qemu-devel@nongnu.org Am 26.09.2012 17:56, schrieb Paolo Bonzini: > The imperative will be used for the QMP command. > > Signed-off-by: Paolo Bonzini I would still be glad if we found a better name. Having two functions block_job_complete() and block_job_completed() sounds like a great source for confusion. Kevin