From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THF6G-00048X-JU for qemu-devel@nongnu.org; Thu, 27 Sep 2012 10:30:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THF66-0000NZ-Ur for qemu-devel@nongnu.org; Thu, 27 Sep 2012 10:30:00 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:46493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THF66-0000Mo-Qc for qemu-devel@nongnu.org; Thu, 27 Sep 2012 10:29:50 -0400 Received: from /spool/local by e4.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Sep 2012 10:29:45 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8RETNxw162218 for ; Thu, 27 Sep 2012 10:29:23 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8RETIHG016805 for ; Thu, 27 Sep 2012 11:29:19 -0300 Message-ID: <506462BC.1040202@linux.vnet.ibm.com> Date: Thu, 27 Sep 2012 10:29:16 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1338838668-7544-1-git-send-email-stefanb@linux.vnet.ibm.com> <1338838668-7544-7-git-send-email-stefanb@linux.vnet.ibm.com> In-Reply-To: <1338838668-7544-7-git-send-email-stefanb@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V19 6/7] Introduce --enable-tpm-passthrough configure option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Berger Cc: mst@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, andreas.niederl@iaik.tugraz.at On 06/04/2012 03:37 PM, Stefan Berger wrote: > Introduce --enable-tpm-passthrough configure option. > > Signed-off-by: Stefan Berger > --- > configure | 16 +++++++++++++++- > 1 files changed, 15 insertions(+), 1 deletions(-) > > diff --git a/configure b/configure > index 804d8c8..8d8bee8 100755 > --- a/configure > +++ b/configure > @@ -195,6 +195,7 @@ guest_agent="yes" > libiscsi="" > coroutine="" > tpm="no" > +tpm_passthrough="no" > > # parse CC options first > for opt do > @@ -827,11 +828,20 @@ for opt do > ;; > --enable-tpm) tpm="yes" > ;; > + --enable-tpm-passthrough) tpm_passthrough="yes" > + ;; > *) echo "ERROR: unknown option $opt"; show_help="yes" > ;; > esac > done > > +if test "$tpm" = "no" ; then > + if test "$tpm_passthrough" = "yes"; then > + echo "ERROR: --enable-tpm-passthrough requires --enable-tpm" > + exit 1 > + fi > +fi > + > # > # If cpu ~= sparc and sparc_cpu hasn't been defined, plug in the right > # QEMU_CFLAGS/LDFLAGS (assume sparc_v8plus for 32-bit and sparc_v9 for 64-bit) > @@ -1114,6 +1124,7 @@ echo " --enable-guest-agent enable building of the QEMU Guest Agent" > echo " --with-coroutine=BACKEND coroutine backend. Supported options:" > echo " gthread, ucontext, sigaltstack, windows" > echo " --enable-tpm enable TPM support" > +echo " --enable-tpm-passthrough enable TPM passthrough driver" > echo "" > echo "NOTE: The object files are built at the place where configure is launched" > exit 1 > @@ -3034,6 +3045,7 @@ echo "libiscsi support $libiscsi" > echo "build guest agent $guest_agent" > echo "coroutine backend $coroutine_backend" > echo "TPM support $tpm" > +echo "TPM passthrough $tpm_passthrough" > > if test "$sdl_too_old" = "yes"; then > echo "-> Your SDL version is too old - please upgrade to have SDL support" > @@ -3919,7 +3931,9 @@ fi > if test "$tpm" = "yes"; then > if test "$target_softmmu" = "yes" ; then > if test "$linux" = "yes" ; then > - echo "CONFIG_TPM_PASSTHROUGH=y" >> $config_host_mak > + if test "$tpm_passthrough" = "yes" ; then > + echo "CONFIG_TPM_PASSTHROUGH=y" >> $config_host_mak > + fi > fi > echo "CONFIG_TPM=y" >> $config_host_mak > fi > This patch looks okay to me. -- Regards, Corey Bryant