From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THF91-0006wb-VZ for qemu-devel@nongnu.org; Thu, 27 Sep 2012 10:32:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THF8s-0001tQ-At for qemu-devel@nongnu.org; Thu, 27 Sep 2012 10:32:51 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:60480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THF8s-0001tG-4O for qemu-devel@nongnu.org; Thu, 27 Sep 2012 10:32:42 -0400 Received: by pbbrp2 with SMTP id rp2so3691468pbb.4 for ; Thu, 27 Sep 2012 07:32:41 -0700 (PDT) Sender: Richard Henderson Message-ID: <50646386.1010102@twiddle.net> Date: Thu, 27 Sep 2012 07:32:38 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1348685335-16770-1-git-send-email-peter.maydell@linaro.org> <1348685335-16770-3-git-send-email-peter.maydell@linaro.org> <5063F326.4070508@redhat.com> In-Reply-To: <5063F326.4070508@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] tcg/arm: Implement movcond_i32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , qemu-devel@nongnu.org, Aurelien Jarno , patches@linaro.org On 09/26/2012 11:33 PM, Paolo Bonzini wrote: > Should you make tcg/optimize.c prefer "movcond a, a, b" to "movcond a, > b, a", similar to commit c2b0e2f (tcg/optimize: prefer the "op a, a, b" > form for commutative ops, 2012-09-19)? I explicitly went with "a, b, a" because I find it is easier to reason with positive logic (move-if-true) than negative logic. r~