From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37429)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1THGRB-0001jG-At
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 11:55:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1THGR4-00081x-8V
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 11:55:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8403)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1THGR3-00081R-VK
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 11:55:34 -0400
Message-ID: <506476E3.9030200@redhat.com>
Date: Thu, 27 Sep 2012 17:55:15 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20120927135553.GD18285@in.ibm.com>
	<20120927135843.GG18285@in.ibm.com>
	<20120927143623.GC27933@redhat.com>
In-Reply-To: <20120927143623.GC27933@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v10 3/5] qemu: URI parsing library
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Anand Avati <aavati@redhat.com>, Vijay Bellur <vbellur@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Harsh Bora <harsh@linux.vnet.ibm.com>, Amar Tumballi <amarts@redhat.com>, qemu-devel@nongnu.org, "Richard W.M. Jones" <rjones@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>, Bharata B Rao <bharata@linux.vnet.ibm.com>, Daniel Veillard <veillard@redhat.com>

Il 27/09/2012 16:36, Daniel P. Berrange ha scritto:
>> > qemu: URI parsing library
>> > 
>> > From: Paolo Bonzini <pbonzini@redhat.com>
>> > 
>> > Add a new URI parsing library to QEMU. The code has been borrowed from
>> > libxml2 and libvirt.
>> > 
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> > Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
>> > ---
>> > 
>> >  Makefile.objs |    2 
>> >  uri.c         | 2249 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> >  uri.h         |  113 +++
> IMHO, you should also be importing the URI code test suite from libvirt
> to verify that the way you merged/changed the codebases did not break
> anything.

Yes, can be done separately though.

Paolo