From: Eric Blake <eblake@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 5/6] QAPI: add command for live block commit, 'block-commit'
Date: Thu, 27 Sep 2012 11:57:02 -0600 [thread overview]
Message-ID: <5064936E.70301@redhat.com> (raw)
In-Reply-To: <327f7d715621f55ee9d1dfd0a3eba6138ffe9345.1348760202.git.jcody@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On 09/27/2012 11:29 AM, Jeff Cody wrote:
> The command for live block commit is added, which has the following
> arguments:
>
> device: the block device to perform the commit on (mandatory)
> base: the base image to commit into; optional (if not specified,
> it is the underlying original image)
> top: the top image of the commit - all data from inside top down
> to base will be committed into base (mandatory for now; see
> note, below)
>
> +++ b/qmp-commands.hx
> @@ -792,6 +792,12 @@ EQMP
> },
>
> {
> + .name = "block-commit",
> + .args_type = "device:B,base:s?,top:s?,speed:o?",
s/top:s?/top:s/ now that top is mandatory.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
next prev parent reply other threads:[~2012-09-27 17:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 17:29 [Qemu-devel] [PATCH v3 0/6] Live block commit Jeff Cody
2012-09-27 17:29 ` [Qemu-devel] [PATCH v3 1/6] block: add support functions for live commit, to find and delete images Jeff Cody
2012-09-27 17:29 ` [Qemu-devel] [PATCH v3 2/6] block: add live block commit functionality Jeff Cody
2012-09-27 17:29 ` [Qemu-devel] [PATCH v3 3/6] blockdev: rename block_stream_cb to a generic block_job_cb Jeff Cody
2012-09-27 17:29 ` [Qemu-devel] [PATCH v3 4/6] block: helper function, to find the base image of a chain Jeff Cody
2012-09-27 17:29 ` [Qemu-devel] [PATCH v3 5/6] QAPI: add command for live block commit, 'block-commit' Jeff Cody
2012-09-27 17:57 ` Eric Blake [this message]
2012-09-27 18:01 ` Jeff Cody
2012-09-27 17:29 ` [Qemu-devel] [PATCH v3 6/6] qemu-iotests: add initial tests for live block commit Jeff Cody
2012-09-27 17:58 ` [Qemu-devel] [PATCH v3 0/6] Live " Eric Blake
2012-09-28 18:23 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5064936E.70301@redhat.com \
--to=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).